Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👌 Improve warnings for invalid filters (add source location and subtype) #1128

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 22, 2024

See tests/test_filter.py, e.g.

srcdir/index.rst:51: WARNING: Filter 'xxx' not valid. Error: name 'xxx' is not defined. [needs.filter]

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.90%. Comparing base (eb81f2e) to head (07a12d5).

Files Patch % Lines
sphinx_needs/roles/need_count.py 33.33% 2 Missing ⚠️
sphinx_needs/directives/needgantt.py 75.00% 1 Missing ⚠️
sphinx_needs/filter_common.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   85.81%   85.90%   +0.08%     
==========================================
  Files          56       56              
  Lines        6505     6511       +6     
==========================================
+ Hits         5582     5593      +11     
+ Misses        923      918       -5     
Flag Coverage Δ
pytests 85.90% <82.60%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisjsewell chrisjsewell changed the title 👌 Improve warnings for bad filters (add source location and subtype) 👌 Improve warnings for invalid filters (add source location and subtype) Feb 22, 2024
@chrisjsewell chrisjsewell merged commit cf5598f into master Feb 23, 2024
18 checks passed
@chrisjsewell chrisjsewell deleted the filter_location branch February 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants