Addition to your PR #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er module augmentation.
| @@ -271,7 +267,7 @@ export interface MiddlewareAPI<S> { | |||
| * asynchronous API call into a series of synchronous actions. | |||
| */ | |||
| export interface Middleware { | |||
| <S>(api: MiddlewareAPI<S>): (next: MiddlewareDispatch) => MiddlewareDispatch; | |||
| <S>(api: MiddlewareAPI<S>): (next: Dispatch<S>) => any; | |||
There was a problem hiding this comment.
Why not Dispatch<S> as result too?
There was a problem hiding this comment.
A middleware can return any result. Take a look to redux-thunk and redux-promise implementations.
|
I'm closing this because it's already contained in your other PR. |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My addition to your PR reduxjs#1526
Take it if it makes sense for you.