Change default optimizations pass to focus on code size #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should invest everything in making contracts as small as possible. Any contract above 50KB wouldn't be viable to run on a parachain anyways. So the optimization time should be negligible. In favor of setting it to |
athei
approved these changes
Jul 20, 2021
HCastano
changed the title
cmichi
requested changes
Jul 21, 2021
There was a problem hiding this comment.
Thank you!
Could you add a ### Changed subsection to the Unreleased section of our CHANGELOG.md: https://github.com/paritytech/cargo-contract/blob/master/CHANGELOG.md ?
I like that a |
cmichi
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default optimization option passed to
wasm-optfrom-O3to-Os-Oz.This saves us around 0.2-0.3K according to these rough benchmarks.
The default wasn't set to-Ozas I saw no noticeable size improvements, and it justtakes more time to run. However, you could also argue that since contracts are in general
quite small the extra time for
-Ozis negligible so we should enable it anyways.While I could be convinced of this, I'm not sure what hardware other people build on, andthe negative impact the change to
-Ozcould have for them.