Fix tests on macOS #303
Merged
Fix tests on macOS #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Tested it locally and it looks good.
We should consider adding some macOS runners to the CI to catch stuff like this (see https://github.com/paritytech/cargo-contract/issues/304).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the tests fails to pass on macOS. The reason is that the temporary pass used is a symlink and one side of the equality used path canonicalization while the other does not.
This PR fixes that by adding canonicalization to the test only
with_tmp_dirfunction.