Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comm: RPC data exchange doesn't enforce message ordering #11

Open
cimes-isi opened this issue Sep 1, 2022 · 0 comments
Open

comm: RPC data exchange doesn't enforce message ordering #11

cimes-isi opened this issue Sep 1, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cimes-isi
Copy link
Collaborator

The RPC stage implementation DistRpcPipelineStage doesn't enforce message ordering, which means we can't verify labels and thus can't measure model accuracy. The primary challenge is that we don't directly manage the PyTorch RPC threads. Furthermore, the current implementation requires the sending stage to wait for the receiver to be ready, which can result in a deadlock if there is a send failure. We could implement queues and threads like with the P2P comm framework, but this is likely to be more challenging to initialize from the master rank, and then you might as well just use the P2P comm framework.

@cimes-isi cimes-isi added the enhancement New feature or request label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant