Skip to content

Fix:(issue_2244) Dont check req flags for help and completion commands#2245

Merged
dearchap merged 1 commit intourfave:mainfrom
dearchap:issue_2244
Jan 18, 2026
Merged

Fix:(issue_2244) Dont check req flags for help and completion commands#2245
dearchap merged 1 commit intourfave:mainfrom
dearchap:issue_2244

Conversation

@dearchap
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2244

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

make test

Release Notes

(REQUIRED)

Help and Completion commands dont check required flags

@dearchap dearchap requested a review from a team as a code owner January 11, 2026 02:46
Copy link

@louisroyer louisroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR, and this works as intended. Thank you 👍

Copy link
Member

@yassinebenaid yassinebenaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

(side note: I kind of don't like how tests are titled. we may need to rephrase them later).

@dearchap dearchap merged commit 07f2236 into urfave:main Jan 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Required global flags are breaking help and completion commands

3 participants