Fix:(issue_2209) Add mutex flags to completion#2212
Fix:(issue_2209) Add mutex flags to completion#2212dearchap wants to merge 4 commits intourfave:mainfrom
Conversation
louisroyer
left a comment
louisroyer
left a comment
There was a problem hiding this comment.
Hi,
I see that when you provide the flag m1, m2 is wrongly suggested (they are mutually exclusive, so the only proposed flags should be l1, l2 and m1).
Could you add this test case as well, and adapt the code to make it pass?
|
@louisroyer |
There was a problem hiding this comment.
m1andm2are part of same group and are exclusive with onlyl2.l1is a global flag and will be valid in all cases.
oh, sorry I only tested against the example program from #2209: last 2 commands were not giving expected result, and tried to transpose this to your test scenario that I wrongly read 😅
Here are the test cases I was thinking about:
Co-authored-by: Louis Royer <55180044+louisroyer@users.noreply.github.com>
2 participants
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #2209
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
go test -run=TestMutuallyExclusiveFlagsCompletion
Release Notes
(REQUIRED)