Add EnableBeforeForHelp option to execute Before functions with help flags #2193
+183
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seipan <yamasakipann0218@gmail.com>
Signed-off-by: seipan <yamasakipann0218@gmail.com>
Signed-off-by: seipan <yamasakipann0218@gmail.com>
seipan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Before functions weren't being executed when users ran
--helpor-hflags, only when using help commands. This created inconsistent behavior and prevented applications from running setup logic (like language configuration)before displaying help text.
Added EnableBeforeForHelp field to make Before function execution configurable for help flags. When set to true, Before functions run for both help commands and help flags. Defaults to false to maintain backward
compatibility.
Which issue(s) this PR fixes:
#2174
Special notes for your reviewer:
non
Testing
Test case for feature.
Release Notes