Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(issue_1921) Dont display [command] in help #2000

Merged
merged 4 commits into from
Nov 2, 2024

Conversation

dearchap
Copy link
Contributor

@dearchap dearchap commented Nov 1, 2024

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Working towards cleaning up help

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #1921

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Updated existing tests

Release Notes

(REQUIRED)

[command] wont be displayed in help if there are no subcommands. 

@dearchap dearchap requested a review from a team as a code owner November 1, 2024 00:10
Copy link
Member

@meatballhat meatballhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to worry about "hide help" settings in the visible commands loop?

@dearchap
Copy link
Contributor Author

dearchap commented Nov 2, 2024

@meatballhat Dont think so.

@dearchap dearchap merged commit 30c4df2 into urfave:main Nov 2, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove [command [command options]] from help text if there are no sub commands
2 participants