Skip to content

Commit 7d9264a

Browse files
committed
Replace a few more custom make targets
1 parent 1a851c7 commit 7d9264a

File tree

2 files changed

+11
-19
lines changed

2 files changed

+11
-19
lines changed

.github/workflows/cli.yml

+11-3
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,15 @@ jobs:
3030
- if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
3131
run: make lint
3232
- run: make vet
33-
- run: make tag-test
33+
- run: make test
34+
env:
35+
FLAGS: -tags urfave_cli_no_docs
3436
- run: make test
3537
- run: make -C cmd/urfave-cli-genflags
3638
- run: make check-binary-size
37-
- run: make tag-check-binary-size
39+
env:
40+
FLAGS: -tags urfave_cli_no_docs
41+
- run: make check-binary-size
3842
- run: make yamlfmt
3943
- run: make diffcheck
4044
- if: matrix.go == '1.19.x' && matrix.os == 'ubuntu-latest'
@@ -59,6 +63,8 @@ jobs:
5963
- uses: actions/checkout@v3
6064
- run: make ensure-gfmrun
6165
- run: make gfmrun
66+
env:
67+
FLAGS: --walk docs/v2/
6268
- run: make diffcheck
6369
publish:
6470
permissions:
@@ -71,7 +77,9 @@ jobs:
7177
- uses: actions/checkout@v3
7278
with:
7379
fetch-depth: 0
74-
- run: make ci-ensure-mkdocs
80+
- run: make ensure-mkdocs
81+
env:
82+
FLAGS: --upgrade-pip
7583
- run: make set-mkdocs-remote
7684
env:
7785
MKDOCS_REMOTE_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Makefile

-16
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,6 @@ all: generate vet tag-test test check-binary-size tag-check-binary-size gfmrun y
1717
%:
1818
$(GO_RUN_BUILD) $(GFLAGS) $* $(FLAGS)
1919

20-
.PHONY: tag-test
21-
tag-test:
22-
$(GO_RUN_BUILD) -tags urfave_cli_no_docs test
23-
24-
.PHONY: tag-check-binary-size
25-
tag-check-binary-size:
26-
$(GO_RUN_BUILD) -tags urfave_cli_no_docs check-binary-size
27-
28-
.PHONY: gfmrun
29-
gfmrun:
30-
$(GO_RUN_BUILD) gfmrun --walk docs/v2/
31-
32-
.PHONY: ci-ensure-mkdocs
33-
ci-ensure-mkdocs:
34-
$(GO_RUN_BUILD) ensure-mkdocs --upgrade-pip
35-
3620
.PHONY: docs
3721
docs:
3822
mkdocs build

0 commit comments

Comments
 (0)