Skip to content

Fix bitop test failing because of old api #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Conversation

ytkimirti
Copy link
Collaborator

Old rest api probably returned the binary result even thought it was invalid utf8. Hence the old code

assert await response.text() == r'{"result":"\x9e\x9d\x9c\x9b"}'

Currently if base64 encoding is not set, it returns � (replacement character), so the test fails.

Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this check altogether (starting from line 57 to 68). This is a client library, and it should not bother with the internal representation of the commands. It should just check if the commands are working.

@ytkimirti ytkimirti merged commit 50e1faf into main Nov 8, 2023
@mdumandag mdumandag deleted the fix-bitop-test branch November 8, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants