fix(react-native): support direct uploads through FormData #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging cee8588 into 2c5dbf8 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 43c50a4 into 2c5dbf8 - view on LGTM.com new alerts:
|
nd0ut
changed the title
|
This pull request introduces 1 alert when merging 59d1be1 into 7606df9 - view on LGTM.com new alerts:
|
foxeyes
approved these changes
Mar 16, 2021
FilippovAM
reviewed
Mar 16, 2021
src/tools/buildFormData.ts
Outdated
| @@ -9,24 +9,26 @@ import { BrowserFile, NodeFile } from '../request/types' | |||
| * in browsers. | |||
| */ | |||
|
|
|||
| type FileTuple = ['file', BrowserFile | NodeFile, string] | |||
| type FileTriple = ['file', BrowserFile | NodeFile, string] | |||
There was a problem hiding this comment.
Typo?
FileTripple => FileTuple?
isFileTriple(tuple)
There was a problem hiding this comment.
This is not typo, triple is 3-tuple. I thought it was better to call this type triple, but now I think it's better to left it as it was. So I reverted it back.
|
This pull request introduces 1 alert when merging be65ca0 into 589ddbe - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Description
We upload small files through XHR and FormData. React-Native has its own implementation of XHR, FormData, Blobs, Files and everything else. And FormData for some reason doesn't support Blob arguments, instead it takes an object of type
{ name?: string; type?: string; uri: string }(see https://github.com/facebook/react-native/blob/master/Libraries/Network/FormData.js#L37)