Add support for numeric timestamps on NullOrDateAssert

Author: Joao Madeiras

README.md

@@ -41,7 +41,7 @@ The following set of extra asserts are provided by this package:
 - [Iso3166Country](#iso3166country) (requires `isoc`)
 - [Json](#json)
 - [NotEmpty](#notempty)
-- [NullOrDate](#nullordate)
+- [NullOrDate](#nullordate) (requires `moment` for format validation only)
 - [NullOrString](#nullorstring)
 - [Phone](#phone) (requires `google-libphonenumber`)
 - [PlainObject](#plainobject)
@@ -152,6 +152,9 @@ Tests if the value is valid json.
 ### NotEmpty
 Tests if the value is not an empty (empty object, empty array, empty string, etc).
 
+### NullOrDate
+Tests if the value is a `null` or `date`.
+
 ### NullOrString
 Tests if the value is a `null` or `string`, optionally within some boundaries.
 

src/asserts/null-or-date-assert.js

@@ -3,34 +3,45 @@
  * Module dependencies.
  */
 
-import { Violation } from 'validator.js';
+import DateAssert from './date-assert';
+import { Assert as BaseAssert, Violation } from 'validator.js';
+
+/**
+ * Extend Assert with `DateAssert`.
+ */
+
+const Assert = BaseAssert.extend({ Date: DateAssert });
 
 /**
  * Export `NullOrDateAssert`.
  */
 
-export default function nullOrDateAssert() {
+export default function nullOrDateAssert({ format } = {}) {
   /**
    * Class name.
    */
 
   this.__class__ = 'NullOrDate';
 
+  /**
+   * Format to match the input.
+   */
+
+  this.format = format;
+
   /**
    * Validation algorithm.
    */
 
   this.validate = value => {
-    if (typeof value !== 'string' && value !== null && Object.prototype.toString.call(value) !== '[object Date]') {
-      throw new Violation(this, value, { value: 'must_be_null_or_a_date' });
-    }
-
     if (value === null) {
       return true;
     }
 
-    if (isNaN(Date.parse(value)) === true) {
-      throw new Violation(this, value);
+    try {
+      new Assert().Date({ format }).validate(value);
+    } catch (e) {
+      throw new Violation(this, value, { value: 'must_be_null_or_a_date_or_a_number' });
     }
 
     return true;

test/asserts/null-or-date-assert_test.js

@@ -20,8 +20,8 @@ const Assert = BaseAssert.extend({
  */
 
 describe('NullOrDateAssert', () => {
-  it('should throw an error if the input value is not a `null` or a date', () => {
-    const choices = [[], {}, 123];
+  it('should throw an error if the input value is not a `null` or a date or a number', () => {
+    const choices = [[], {}];
 
     choices.forEach(choice => {
       try {
@@ -30,7 +30,7 @@ describe('NullOrDateAssert', () => {
         should.fail();
       } catch (e) {
         e.should.be.instanceOf(Violation);
-        e.violation.value.should.equal('must_be_null_or_a_date');
+        e.violation.value.should.equal('must_be_null_or_a_date_or_a_number');
       }
     });
   });
@@ -46,6 +46,28 @@ describe('NullOrDateAssert', () => {
     }
   });
 
+  it('should throw an error if the input value is an invalid timestamp', () => {
+    try {
+      new Assert().NullOrDate().validate(-Number.MAX_VALUE);
+
+      should.fail();
+    } catch (e) {
+      e.should.be.instanceOf(Violation);
+      e.show().assert.should.equal('NullOrDate');
+    }
+  });
+
+  it('should throw an error if value does not pass strict validation', () => {
+    try {
+      new Assert().NullOrDate({ format: 'YYYY-MM-DD' }).validate('2000.12.30');
+
+      should.fail();
+    } catch (e) {
+      e.should.be.instanceOf(Violation);
+      e.show().assert.should.equal('NullOrDate');
+    }
+  });
+
   it('should expose `assert` equal to `NullOrDate`', () => {
     try {
       new Assert().NullOrDate().validate({});
@@ -64,7 +86,19 @@ describe('NullOrDateAssert', () => {
     new Assert().NullOrDate().validate(new Date());
   });
 
+  it('should accept a correctly formatted date', () => {
+    new Assert().NullOrDate({ format: 'YYYY' }).validate('2000');
+  });
+
   it('should accept a string', () => {
     new Assert().NullOrDate().validate('2014-10-16');
   });
+
+  it('should accept an ISO-8601 string date', () => {
+    new Assert().NullOrDate().validate('2016-04-23T00:51:18.570Z');
+  });
+
+  it('should accept a numeric timestamp', () => {
+    new Assert().NullOrDate().validate(Date.now());
+  });
 });