Support for S3 download urls: presigned urls, S3 etag #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hes, no auth is sent s3 etag support: if hash type is 'etag', use either md5 or double-md5 as served by s3 (https://zihao.me/post/calculating-etag-for-aws-s3-objects/)
somexpert
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for WASAPI download urls that are Amazon S3 urls, and will make the client work correctly with the Webrecorder WASAPI implementation.
It includes two parts:
Allow skipping the auth header if a url matches a certain pattern, so far just the Amazon S3 pre-signed urls (containing a signature). The pre-signed urls can be used directly to download WARCs for a limited amount of time and due to require additional auth (and will be rejected if there is an auth header):
https://boto3.amazonaws.com/v1/documentation/api/latest/guide/s3-presigned-urls.html
Treat the special
etaghash algorithm as either an md5 or a double-md5.If it encounters
etag, it checks to see if the checksum has a-, if not, its a regular md5Otherwise, compute the 'double-md5' as suggested: https://zihao.me/post/calculating-etag-for-aws-s3-objects/