Skip to content

Commit c00703b

Browse files
committed
Build all bundles required by flight fixture with build-for-flight-dev
The following bundles were missing so that the flight fixture could not be started after running `yarn build-for-flight-dev` on a fresh clone: - `react-server-dom-webpack-node-loader.production.js` (requires `ESM_PROD`) - `react-server-dom-webpack-plugin.js` (requires `NODE_ES2015`) - `react-dom.react-server.development.js` - `react.react-server.development.js` Since we now need to specify a list of bundle types, we had to fix the `shouldSkipBundle` function, which apparently was broken in facebook#29906.
1 parent 3208e73 commit c00703b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@
113113
"build-for-devtools": "cross-env RELEASE_CHANNEL=experimental yarn build react/index,react/jsx,react/compiler-runtime,react-dom/index,react-dom/client,react-dom/unstable_testing,react-dom/test-utils,react-is,react-debug-tools,scheduler,react-test-renderer,react-refresh,react-art --type=NODE",
114114
"build-for-devtools-dev": "yarn build-for-devtools --type=NODE_DEV",
115115
"build-for-devtools-prod": "yarn build-for-devtools --type=NODE_PROD",
116-
"build-for-flight-dev": "cross-env RELEASE_CHANNEL=experimental node ./scripts/rollup/build.js react/index,react/jsx,react-dom/index,react-dom/client,react-dom/server,react-dom-server.node,react-dom-server-legacy.node,scheduler,react-server-dom-webpack/ --type=NODE_DEV && mv ./build/node_modules ./build/oss-experimental",
116+
"build-for-flight-dev": "cross-env RELEASE_CHANNEL=experimental node ./scripts/rollup/build.js react/index,react/jsx,react.react-server,react-dom/index,react-dom/client,react-dom/server,react-dom.react-server,react-dom-server.node,react-dom-server-legacy.node,scheduler,react-server-dom-webpack/ --type=NODE_DEV,ESM_PROD,NODE_ES2015 && mv ./build/node_modules ./build/oss-experimental",
117117
"linc": "node ./scripts/tasks/linc.js",
118118
"lint": "node ./scripts/tasks/eslint.js",
119119
"lint-build": "node ./scripts/rollup/validate/index.js",

scripts/rollup/build.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,10 @@ function shouldSkipBundle(bundle, bundleType) {
540540
return true;
541541
}
542542
if (requestedBundleTypes.length > 0) {
543-
const isAskingForDifferentType = requestedBundleTypes.some(
544-
requestedType => !bundleType.includes(requestedType)
543+
const hasRequestedBundleType = requestedBundleTypes.some(requestedType =>
544+
bundleType.includes(requestedType)
545545
);
546-
if (isAskingForDifferentType) {
546+
if (!hasRequestedBundleType) {
547547
return true;
548548
}
549549
}

0 commit comments

Comments
 (0)