fix: update brand loading variants for consistent sizing #1223

zackspear · 2025-03-14T01:03:27Z

I was seeing strange behavior on /Tools/Registration when forcing the check that happens on page load to fire again. The brand logo SVG was rendering very large. So I set the size to small. But the SVG was still rendering strangely due to the square width and height classes.

In the SVG source code, I took viewBox="0 0 133.52 76.97" and converted that to an aspect ratio, 133.52/76.97. And for simpler integers - 133.52/76.97 ≈ 1.735 which is close to 7/4 (1.75). So we can use - aspect-[7/4].

Summary by CodeRabbit

Style
- Enhanced the brand loading component’s appearance by enforcing a consistent aspect ratio and streamlining its dimension settings to focus solely on width parameters.

- Adjusted the `brandLoadingVariants` to include an aspect ratio for better layout control. - Modified size variants to only specify width, allowing for automatic height adjustment. This change improves the visual consistency of the loading component across different screen sizes.

- Changed the aspect ratio in `brandLoadingVariants` from `[133.52/76.97]` to `[7/4]` for improved layout consistency.

coderabbitai · 2025-03-14T01:03:34Z

Walkthrough

The pull request updates the brandLoadingVariants export in the brand-loading.variants.ts file. The changes add an aspect-[7/4] class to the component for a fixed aspect ratio. Additionally, the size variants have been adjusted by removing height classes (such as h-12, h-16, h-20, and h-full) to rely solely on width classes (like w-12, w-16, w-20, and w-full).

Changes

File	Change Summary
unraid-ui/src/components/brand/brand-loading.variants.ts	Modified `brandLoadingVariants`: added `aspect-[7/4]` class; removed height classes, retaining only width classes.

Poem

In a flutter of code, a new ratio appears,
With widths standing tall and heights no longer near.
A precise tweak for a refined design spin,
Brand loading shines with a confident grin—
A code celebration where style and function win!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 1f00212 and d76b04a.

📒 Files selected for processing (1)

unraid-ui/src/components/brand/brand-loading.variants.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: Test API
GitHub Check: Build Web App
GitHub Check: Build API
GitHub Check: Cloudflare Pages

🔇 Additional comments (2)

unraid-ui/src/components/brand/brand-loading.variants.ts (2)

3-3: Addition of aspect ratio class resolves sizing inconsistency

Adding the aspect-[7/4] class to the base styling is a good solution for maintaining consistent proportions of the brand logo. This aspect ratio (1.75) closely matches the SVG's natural dimensions based on its viewBox (133.52/76.97 ≈ 1.735).

This change will prevent the logo from stretching or becoming disproportionately large during page transitions or reloads.

11-14: Simplified size variants by removing height constraints

Removing the height classes (h-12, h-16, etc.) while keeping only width classes is a logical improvement that works hand-in-hand with the new aspect ratio approach. With a fixed aspect ratio in place, controlling only the width is sufficient as the height will automatically adjust to maintain the 7:4 ratio.

This change reduces potential styling conflicts and simplifies the component's sizing model.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-03-14T01:06:47Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL:

https://preview.dl.unraid.net/unraid-api/tag/PR1223/dynamix.unraid.net.plg

🤖 I have created a release *beep* *boop* --- ## [4.2.0](v4.1.3...v4.2.0) (2025-03-18) ### Features * add resolver for logging ([#1222](#1222)) ([2d90408](2d90408)) * connect settings web component ([#1211](#1211)) ([653de00](653de00)) * improve local dev with install path ([#1221](#1221)) ([32c5b0a](32c5b0a)) * split plugin builds ([4d10966](4d10966)) * swap to absolute paths for css ([#1224](#1224)) ([6f9fa10](6f9fa10)) * update theme application logic and color picker ([#1181](#1181)) ([c352f49](c352f49)) * use patch version if needed on update check ([#1227](#1227)) ([6ed46b3](6ed46b3)) ### Bug Fixes * add INELIGIBLE state to ConfigErrorState enum ([#1220](#1220)) ([1f00212](1f00212)) * **api:** dynamix notifications dir during development ([#1216](#1216)) ([0a382ca](0a382ca)) * **api:** type imports from generated graphql types ([#1215](#1215)) ([fd02297](fd02297)) * **deps:** update dependency @nestjs/schedule to v5 ([#1197](#1197)) ([b1ff6e5](b1ff6e5)) * **deps:** update dependency @vueuse/core to v12 ([#1199](#1199)) ([d8b8339](d8b8339)) * fix changelog thing again ([2426345](2426345)) * fix invalid path to node with sh execution ([#1213](#1213)) ([d12448d](d12448d)) * load tag correctly ([acd692b](acd692b)) * log errors ([629feda](629feda)) * one-command dev & web env files ([#1214](#1214)) ([8218fab](8218fab)) * re-release fixed ([bb526b5](bb526b5)) * recreate watcher on path change ([#1203](#1203)) ([5a9154e](5a9154e)) * update brand loading variants for consistent sizing ([#1223](#1223)) ([d7a4b98](d7a4b98)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

zackspear added 2 commits March 13, 2025 17:54

fix: update aspect ratio in brand loading variants

d76b04a

- Changed the aspect ratio in `brandLoadingVariants` from `[133.52/76.97]` to `[7/4]` for improved layout consistency.

zackspear requested a review from mdatelle March 14, 2025 01:03

zackspear requested review from elibosley and pujitm March 14, 2025 01:03

elibosley approved these changes Mar 14, 2025

View reviewed changes

elibosley merged commit d7a4b98 into main Mar 14, 2025
8 checks passed

elibosley deleted the fix/brand-loading branch March 14, 2025 14:05

github-actions bot mentioned this pull request Mar 14, 2025

chore(main): release 4.2.0 #1189

Merged

This was referenced Mar 18, 2025

chore(main): release 4.1.2 #1234

Closed

chore(main): release 4.3.0 #1237

Merged

chore(main): release 4.3.1 #1239

Merged

chore(main): release 4.4.0 #1241

Merged

chore(main): release 4.4.1 #1270

Merged

This was referenced Mar 27, 2025

chore(main): release 4.5.0 #1276

Closed

chore(main): release 4.5.0 #1279

Merged

chore(main): release 4.6.0 #1311

Merged

This was referenced Apr 3, 2025

chore(main): release 4.6.1 #1322

Merged

chore(main): release 4.6.2 #1323

Merged

chore(main): release 4.6.3 #1324

Merged

chore(main): release 4.6.4 #1325

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: update brand loading variants for consistent sizing #1223

fix: update brand loading variants for consistent sizing #1223

Uh oh!

zackspear commented Mar 14, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Mar 14, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

fix: update brand loading variants for consistent sizing #1223

fix: update brand loading variants for consistent sizing #1223

Uh oh!

Conversation

zackspear commented Mar 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Mar 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zackspear commented Mar 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)