feat: sidebar notification count

[elibosley]

Summary by CodeRabbit

• New Features
  • Introduced a computed property to accurately display the count of archived notifications that are not unread.
• Bug Fixes
  • Updated archived notifications count to exclude unread notifications, providing a more accurate count of read archived notifications.
• Style
  • Improved readability of the confirmation dialog for deleting archived notifications by splitting the message into multiple lines.

[coderabbitai]

Walkthrough

The pull request modifies the Sidebar.vue component in the web application, specifically adjusting how archived notifications are counted and displayed. A new computed property, readArchivedCount, is introduced to calculate the number of archived notifications that are not unread, enhancing the accuracy of the displayed count. Additionally, minor formatting changes are made to the confirmation dialog for deleting archived notifications, improving readability.

Changes

File	Change Summary
web/components/Notifications/Sidebar.vue	Added readArchivedCount computed property for accurate archived notifications count; updated template to reflect this change; minor formatting adjustments in the confirmation dialog.

Possibly related PRs

• feat(web): add an 'all' option to notification filter #964: Changes in Sidebar.vue related to notification handling and deletion functionalities may connect with the modifications made in the main PR, which also involves the Sidebar.vue component.
• fix(web): update unread total immediately upon archiving #982: The update to the Apollo cache management for notifications in web/helpers/apollo-cache/index.ts includes logic for handling archived notifications, which is relevant to the changes made in the main PR regarding archived notifications.
• feat(web): clear notifications indicator after opening sidebar #1001: The addition of the seen property in both Indicator.vue and Sidebar.vue relates to the handling of notification visibility, which aligns with the main PR's focus on improving the display of archived notifications.

Poem

🐰 Hop, hop, through notification lanes,
Counting archives with mathematical brains,
Unread messages now subtly concealed,
A rabbit's count, precisely revealed!
Archived wisdom, clean and bright ✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between de975b5 and 30e8030.

📒 Files selected for processing (1)

• web/components/Notifications/Sidebar.vue (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• web/components/Notifications/Sidebar.vue

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build Web App
• GitHub Check: Build and Test API
• GitHub Check: Cloudflare Pages

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

web/components/Notifications/Sidebar.vue (1)

91-91: Consider clarifying the count label.

The current label "Archived" with the count might be misleading as it shows only read archived notifications, not the total archived count.

Consider updating the label to be more explicit:

- Archived <span v-if="overview">({{ readArchivedCount }})</span>
+ Read Archive <span v-if="overview">({{ readArchivedCount }})</span>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between ebcd347 and 5ef417a.

📒 Files selected for processing (1)

• web/components/Notifications/Sidebar.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Build Web App
• GitHub Check: Build and Test API
• GitHub Check: Cloudflare Pages

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL: https://preview.dl.unraid.net/unraid-api/pr/1042/dynamix.unraid.net.staging.plg

[pujitm]

one comment, otherwise lgtm

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL: https://preview.dl.unraid.net/unraid-api/pr/1042/dynamix.unraid.net.staging.plg

[github-actions]

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL: https://preview.dl.unraid.net/unraid-api/pr/1042/dynamix.unraid.net.staging.plg