port setup_api.sh

Author: pujitm

api/src/environment.ts

@@ -99,6 +99,7 @@ export const MOTHERSHIP_GRAPHQL_LINK = process.env.MOTHERSHIP_GRAPHQL_LINK
 export const PM2_HOME = process.env.PM2_HOME ?? join(homedir(), '.pm2');
 export const PM2_PATH = join(import.meta.dirname, '../../', 'node_modules', 'pm2', 'bin', 'pm2');
 export const ECOSYSTEM_PATH = join(import.meta.dirname, '../../', 'ecosystem.config.json');
+export const LOGS_DIR = process.env.LOGS_DIR ?? '/var/log/unraid-api';
 
 export const PATHS_CONFIG_MODULES =
     process.env.PATHS_CONFIG_MODULES ?? '/boot/config/plugins/dynamix.my.servers/configs';

api/src/unraid-api/cli/pm2.service.ts

@@ -1,12 +1,12 @@
 import { Injectable } from '@nestjs/common';
 import { existsSync } from 'node:fs';
-import { rm } from 'node:fs/promises';
+import { mkdir, rm } from 'node:fs/promises';
 import { join } from 'node:path';
 
 import type { Options, Result, ResultPromise } from 'execa';
 import { execa, ExecaError } from 'execa';
 
-import { PM2_HOME, PM2_PATH } from '@app/environment.js';
+import { LOGS_DIR, PM2_HOME, PM2_PATH } from '@app/environment.js';
 import { LogService } from '@app/unraid-api/cli/log.service.js';
 
 type CmdContext = Options & {
@@ -97,4 +97,11 @@ export class PM2Service {
             this.logger.trace('PM2 home directory does not exist.');
         }
     }
+
+    /**
+     * Ensures that the dependencies necessary for PM2 to start and operate are present.
+     */
+    async ensurePm2Dependencies() {
+        await mkdir(LOGS_DIR, { recursive: true });
+    }
 }

api/src/unraid-api/cli/start.command.ts

@@ -20,6 +20,7 @@ export class StartCommand extends CommandRunner {
     }
 
     async cleanupPM2State() {
+        await this.pm2.ensurePm2Dependencies();
         await this.pm2.run({ tag: 'PM2 Stop' }, 'stop', ECOSYSTEM_PATH);
         await this.pm2.run({ tag: 'PM2 Update' }, 'update');
         await this.pm2.deleteDump();

plugin/source/dynamix.unraid.net/install/doinst.sh

@@ -1,6 +1,26 @@
 #!/bin/sh
 
+backup_file_if_exists() {
+  if [ -f "$1" ]; then
+    mv "$1" "$1.old"
+  fi
+}
+
+chmod 755 etc/rc.d/rc6.d/K*unraid-api
+chmod 755 etc/rc.d/rc6.d/K*flash-backup
+
+chmod +x usr/local/unraid-api/dist/cli.js
+chmod +x usr/local/unraid-api/dist/main.js
+
 rm -rf usr/local/bin/unraid-api
 ln -sf usr/local/unraid-api/dist/cli.js usr/local/bin/unraid-api
+# deprecated
+ln -sf usr/local/bin/unraid-api usr/local/sbin/unraid-api
+ln -sf usr/local/bin/unraid-api usr/bin/unraid-api
+
+# By default, we want to overwrite the active api-specific .env configuration on every install.
+# We keep a backup in case a user needs to revert to their prior configuration.
+backup_file_if_exists usr/local/unraid-api/.env
+cp usr/local/unraid-api/.env.production usr/local/unraid-api/.env
 
 # auto-generated actions from makepkg:

plugin/source/dynamix.unraid.net/usr/local/share/dynamix.unraid.net/install/scripts/setup_api.sh

@@ -19,65 +19,6 @@ else
   echo "Env file already exists"
 fi
 
-# Create log directory (PM2 will not start without it)
-mkdir -p /var/log/unraid-api
-echo "Created log directory at /var/log/unraid-api"
-
-# Create Symlinks for the Unraid API
-if [ -f "${API_BASE_DIR}/dist/cli.js" ]; then
-  echo "Creating symlinks for unraid-api"
-  ln -sf "${API_BASE_DIR}/dist/cli.js" "/usr/local/bin/unraid-api"
-  ln -sf "/usr/local/bin/unraid-api" "/usr/local/sbin/unraid-api"
-  ln -sf "/usr/local/bin/unraid-api" "/usr/bin/unraid-api"
-  
-  # Verify symlinks were created
-  if [ -L "/usr/local/bin/unraid-api" ]; then
-    echo "Symlinks created successfully"
-  else
-    echo "ERROR: Failed to create symlinks"
-  fi
-  
-  # Make API scripts executable
-  echo "Making API scripts executable"
-  chmod +x "${API_BASE_DIR}/dist/cli.js"
-  chmod +x "${API_BASE_DIR}/dist/main.js"
-  echo "API scripts are now executable"
-else
-  echo "ERROR: Source file ${API_BASE_DIR}/dist/cli.js does not exist"
-  
-  # Check if the directory exists
-  if [ -d "${API_BASE_DIR}" ]; then
-    echo "API base directory exists"
-    ls -la "${API_BASE_DIR}"
-    
-    if [ -d "${API_BASE_DIR}/dist" ]; then
-      echo "Dist directory exists"
-      ls -la "${API_BASE_DIR}/dist"
-    else
-      echo "Dist directory does not exist"
-    fi
-  else
-    echo "API base directory does not exist"
-  fi
-fi
-
-# Copy env file
-if [ -f "${API_BASE_DIR}/.env.production" ]; then
-  echo "Copying .env.production to .env"
-  cp "${API_BASE_DIR}/.env.production" "${API_BASE_DIR}/.env"
-else
-  echo "ERROR: .env.production file not found"
-fi
-
-# Ensure rc directories exist and scripts are executable
-echo "Ensuring shutdown scripts are executable"
-if [ -d "/etc/rc.d/rc6.d" ]; then
-  chmod 755 /etc/rc.d/rc6.d/K*unraid-api 2>/dev/null
-  chmod 755 /etc/rc.d/rc6.d/K*flash-backup 2>/dev/null
-else
-  echo "Warning: rc6.d directory does not exist"
-fi
-
 # Create symlink for rc0.d to rc6.d if needed
 if [ ! -L /etc/rc.d/rc0.d ] && [ ! -d /etc/rc.d/rc0.d ]; then
   echo "Creating symlink from /etc/rc.d/rc0.d to /etc/rc.d/rc6.d"