restart api after removal, fix version upon load

Author: pujitm

api/src/unraid-api/config/api-config.module.ts

@@ -1,4 +1,4 @@
-import { Injectable, Logger, Module } from '@nestjs/common';
+import { Injectable, Logger, Module, OnApplicationBootstrap } from '@nestjs/common';
 import { ConfigService, registerAs } from '@nestjs/config';
 import path from 'path';
 
@@ -50,7 +50,10 @@ export const loadApiConfig = async () => {
 export const apiConfig = registerAs<ApiConfig>('api', loadApiConfig);
 
 @Injectable()
-export class ApiConfigPersistence extends ConfigFilePersister<ApiConfig> {
+export class ApiConfigPersistence
+    extends ConfigFilePersister<ApiConfig>
+    implements OnApplicationBootstrap
+{
     constructor(configService: ConfigService) {
         super(configService);
     }
@@ -79,12 +82,17 @@ export class ApiConfigPersistence extends ConfigFilePersister<ApiConfig> {
         return createDefaultConfig();
     }
 
+    async onApplicationBootstrap() {
+        this.configService.set('api.version', API_VERSION);
+    }
+
     async migrateConfig(): Promise<ApiConfig> {
         const legacyConfig = this.configService.get('store.config', {});
         const migrated = this.convertLegacyConfig(legacyConfig);
         return {
             ...this.defaultConfig(),
             ...migrated,
+            version: API_VERSION,
         };
     }
 

packages/unraid-shared/src/util/config-file-handler.ts

@@ -122,7 +122,7 @@ export class ConfigFileHandler<T extends object> {
 
     try {
       const data = JSON.stringify(config, null, 2);
-      this.logger.verbose("Writing config");
+      this.logger.verbose(`Writing config to ${this.definition.configPath()} ${data}`);
       await writeFile(this.definition.configPath(), data);
       return true;
     } catch (error) {

plugin/plugins/dynamix.unraid.net.plg

@@ -198,7 +198,7 @@ exit 0
       
       if [ "$is_7_2_or_higher" = true ]; then
         echo "Unraid 7.2+ detected. Using safe removal method."
-        /etc/rc.d/rc.unraid-api plugins remove unraid-api-plugin-connect -b --no-restart
+        /etc/rc.d/rc.unraid-api plugins remove unraid-api-plugin-connect -b
 
         # Send notification to user
         /usr/local/emhttp/webGui/scripts/notify \