refactor(api): delete only archived notifications in deleteAll

Author: pujitm

api/src/graphql/generated/api/types.ts

@@ -632,6 +632,7 @@ export type Mutation = {
   connectSignIn: Scalars['Boolean']['output'];
   connectSignOut: Scalars['Boolean']['output'];
   createNotification: Notification;
+  /** Deletes all archived notifications on server. */
   deleteAllNotifications: NotificationOverview;
   deleteNotification: NotificationOverview;
   /** Delete a user */

api/src/graphql/schema/types/notifications/notifications.graphql

@@ -17,6 +17,9 @@ type Query {
 type Mutation {
     createNotification(input: NotificationData!): Notification!
     deleteNotification(id: String!, type: NotificationType!): NotificationOverview!
+    """
+    Deletes all archived notifications on server.
+    """
     deleteAllNotifications: NotificationOverview!
     """
     Marks a notification as archived.

api/src/unraid-api/graph/resolvers/notifications/notifications.resolver.ts

@@ -3,14 +3,14 @@ import { Args, Mutation, Query, ResolveField, Resolver, Subscription } from '@ne
 
 import { UseRoles } from 'nest-access-control';
 
-import type {
+import { AppError } from '@app/core/errors/app-error';
+import { createSubscription, PUBSUB_CHANNEL } from '@app/core/pubsub';
+import {
     NotificationData,
     NotificationFilter,
     NotificationOverview,
     NotificationType,
 } from '@app/graphql/generated/api/types';
-import { AppError } from '@app/core/errors/app-error';
-import { createSubscription, PUBSUB_CHANNEL } from '@app/core/pubsub';
 import { Importance } from '@app/graphql/generated/client/graphql';
 
 import { NotificationsService } from './notifications.service';
@@ -74,7 +74,7 @@ export class NotificationsResolver {
 
     @Mutation()
     public async deleteAllNotifications(): Promise<NotificationOverview> {
-        return this.notificationsService.deleteAllNotifications();
+        return this.notificationsService.deleteNotifications(NotificationType.ARCHIVE);
     }
 
     @Mutation()

api/src/unraid-api/graph/resolvers/notifications/notifications.service.ts

@@ -292,33 +292,34 @@ export class NotificationsService {
     }
 
     /**
-     * Deletes all notifications from disk, but preserves
-     * notification directories.
+     * Deletes all notifications of a specific type and resets their overview stats.
      *
-     * Resets the notification overview to all zeroes.
+     * @param type - The type of notifications to delete (UNREAD or ARCHIVE)
+     * @remarks Ensures the notifications directory exists before emptying it
      */
-    public async deleteAllNotifications() {
-        const { UNREAD, ARCHIVE } = this.paths();
-        // ensures the directory exists before deleting
-        await emptyDir(ARCHIVE);
-        await emptyDir(UNREAD);
-        NotificationsService.overview = {
-            unread: {
-                alert: 0,
-                info: 0,
-                warning: 0,
-                total: 0,
-            },
-            archive: {
-                alert: 0,
-                info: 0,
-                warning: 0,
-                total: 0,
-            },
+    public async deleteNotifications(type: NotificationType) {
+        await emptyDir(this.paths()[type]);
+        NotificationsService.overview[type.toLowerCase()] = {
+            alert: 0,
+            info: 0,
+            warning: 0,
+            total: 0,
         };
         return this.getOverview();
     }
 
+    /**
+     * Deletes all notifications from disk while preserving the directory structure.
+     * Resets overview stats to zero.
+     *
+     * @returns The updated notification overview stats
+     */
+    public async deleteAllNotifications() {
+        await this.deleteNotifications(NotificationType.ARCHIVE);
+        await this.deleteNotifications(NotificationType.UNREAD);
+        return this.getOverview();
+    }
+
     /**------------------------------------------------------------------------
      *                           CRUD: Updating Notifications
      *------------------------------------------------------------------------**/
@@ -700,7 +701,7 @@ export class NotificationsService {
     }
 
     private parseNotificationDateToIsoDate(unixStringSeconds: string | undefined): Date | null {
-        const timeStamp = Number(unixStringSeconds)
+        const timeStamp = Number(unixStringSeconds);
         if (unixStringSeconds && !Number.isNaN(timeStamp)) {
             return new Date(timeStamp * 1_000);
         }

web/components/Notifications/Sidebar.vue

@@ -22,7 +22,7 @@ const confirmAndArchiveAll = async () => {
 
 const confirmAndDeleteAll = async () => {
   if (
-    confirm('This will permanently delete all notifications currently on your Unraid server. Continue?')
+    confirm('This will permanently delete all archived notifications currently on your Unraid server. Continue?')
   ) {
     await deleteAll();
   }