add utility for creating exception-safe "runner" functions

Author: pujitm

packages/unraid-api-plugin-connect/src/service/url-resolver.service.ts

@@ -2,6 +2,7 @@ import { Injectable, Logger } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 
 import { URL_TYPE } from '@unraid/shared/network.model.js';
+import { makeSafeRunner } from '@unraid/shared/util/processing.js';
 
 import { ConfigType } from '../model/connect-config.model.js';
 
@@ -268,17 +269,13 @@ export class UrlResolverService {
         const errors: Error[] = [];
         const urls: AccessUrl[] = [];
 
-        const doSafely = (fn: () => void) => {
-            try {
-                fn();
-            } catch (error: unknown) {
-                if (error instanceof Error) {
-                    errors.push(error);
-                } else {
-                    this.logger.warn(error, 'Uncaught error in network resolver');
-                }
+        const doSafely = makeSafeRunner((error) => {
+            if (error instanceof Error) {
+                errors.push(error);
+            } else {
+                this.logger.warn(error, 'Uncaught error in network resolver');
             }
-        };
+        });
 
         doSafely(() => {
             const defaultUrl = new URL(nginx.defaultUrl);

packages/unraid-shared/src/util/processing.ts

@@ -0,0 +1,33 @@
+// Utils related to processing operations
+// e.g. parallel processing, safe processing, etc.
+
+/**
+ * Creates a function that runs a given function and catches any errors.
+ * If an error is caught, it is passed to the `onError` function.
+ *
+ * @param onError - The function to call if an error is caught.
+ * @returns A function that runs the given function and catches any errors.
+ * @example
+ * const errors: Error[] = [];
+ * const doSafely = makeSafeRunner((error) => {
+ *   if (error instanceof Error) {
+ *     errors.push(error);
+ *   } else {
+ *     this.logger.warn(error, 'Uncaught error in network resolver');
+ *   }
+ * });
+ *
+ * doSafely(() => {
+ *   JSON.parse(aFile);
+ *   throw new Error('test');
+ * });
+ */
+export function makeSafeRunner(onError: (error: unknown) => void) {
+  return <T>(fn: () => T) => {
+    try {
+      return fn();
+    } catch (error) {
+      onError(error);
+    }
+  };
+}