Skip to content

feat(element-plus): add noStylesComponents for resolver options #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/core/resolvers/element-plus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export interface ElementPlusResolverOptions {
* exclude component name, if match do not resolve the name
*/
exclude?: RegExp

/**
* a list of component names that have no styles, so resolving their styles file should be prevented
*/
noStylesComponents?: string[]
}

type ElementPlusResolverOptionsResolved = Required<Omit<ElementPlusResolverOptions, 'exclude'>> &
Expand Down Expand Up @@ -145,7 +150,7 @@ function resolveDirective(name: string, options: ElementPlusResolverOptionsResol
}
}

const noStylesComponent = ['ElAutoResizer']
const noStylesComponents = ['ElAutoResizer']

/**
* Resolver for Element Plus
Expand All @@ -171,6 +176,7 @@ export function ElementPlusResolver(
importStyle: 'css',
directives: true,
exclude: undefined,
noStylesComponents: options.noStylesComponents || [],
...options,
}
return optionsResolved
Expand All @@ -182,7 +188,7 @@ export function ElementPlusResolver(
resolve: async (name: string) => {
const options = await resolveOptions()

if (noStylesComponent.includes(name))
if ([...options.noStylesComponents, ...noStylesComponents].includes(name))
return resolveComponent(name, { ...options, importStyle: false })
else return resolveComponent(name, options)
},
Expand Down