Skip to content

Commit e1b0cc0

Browse files
committed
chore: cleanup
1 parent 62bc418 commit e1b0cc0

File tree

1 file changed

+14
-16
lines changed

1 file changed

+14
-16
lines changed

src/resolvers/element-plus.ts

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import compareVersions from 'compare-versions'
1+
import gt from 'compare-versions'
22
import { ComponentResolver, SideEffectsInfo } from '../types'
33
import { getPkgVersion, kebabCase } from '../utils'
4+
45
export interface ElementPlusResolverOptions {
56
/**
67
* import style css or sass with components
@@ -24,7 +25,7 @@ export interface ElementPlusResolverOptions {
2425
*
2526
* @returns
2627
*/
27-
function getSideEffectsLagency(
28+
function getSideEffectsLegacy(
2829
partialName: string,
2930
options: ElementPlusResolverOptions,
3031
): SideEffectsInfo | undefined {
@@ -71,34 +72,31 @@ export function ElementPlusResolver(
7172
): ComponentResolver {
7273
return (name: string) => {
7374
if (name.match(/^El[A-Z]/)) {
74-
let { version } = options
75-
if (!version)
76-
version = getPkgVersion('element-plus', '1.0.2')
77-
let sideEffects
75+
const {
76+
version = getPkgVersion('element-plus', '1.0.2'),
77+
} = options
7878
const partialName = kebabCase(name.slice(2))// ElTableColumn->table-column
79-
if (compareVersions(version, '1.1.0-beta.1') >= 0) {
80-
// >=1.1.0-beta.1
81-
sideEffects = getSideEffects(partialName, options)
79+
80+
// >=1.1.0-beta.1
81+
if (gt(version, '1.1.0-beta.1')) {
8282
return {
8383
importName: name,
8484
path: 'element-plus/es',
85-
sideEffects,
85+
sideEffects: getSideEffects(partialName, options),
8686
}
8787
}
88-
else if (compareVersions(version, '1.0.2-beta.28') >= 0) {
8988
// >=1.0.2-beta.28
90-
sideEffects = getSideEffectsLagency(partialName, options)
89+
else if (gt(version, '1.0.2-beta.28')) {
9190
return {
9291
path: `element-plus/es/el-${partialName}`,
93-
sideEffects,
92+
sideEffects: getSideEffectsLegacy(partialName, options),
9493
}
9594
}
95+
// for <=1.0.1
9696
else {
97-
// for 1.0.1
98-
sideEffects = getSideEffectsLagency(partialName, options)
9997
return {
10098
path: `element-plus/lib/el-${partialName}`,
101-
sideEffects,
99+
sideEffects: getSideEffectsLegacy(partialName, options),
102100
}
103101
}
104102
}

0 commit comments

Comments
 (0)