-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Skia] Restore Runtime Tests #7271
Comments
For other selection tests, |
Anyway, instead of completely disable this test, let's turn the check into EDIT: Actually |
We can enable those back one we find the proper fixes, the point of the associated PR is to have regression validation. For the ValidateLayoutRoundingForPixelDimensions is suspect this is related to DPI awareness. |
@morning4coffe-dev maybe you could look into some of these |
In reference to I've checked Skia and WPF and both fails, but I can't find the same test for WinUI. When repeater is set Line 279 in 52c6091
It takes only three child elements so, why it should be 4? Line 300 in 52c6091
@jeromelaban is there a way to compare the UNO Windows.UI.Xaml.FrameworkElement with the MS version? |
I took a look at while (m_elementManager.IsIndexValidInData(currentIndex) &&
(disableVirtualization || ShouldContinueFillingUpSpace(previousIndex, direction))) For some reason, it only realizes three elements whereas in Windows it realizes four. I couldn't go further with this. 😕 |
Current behavior
After the introduction of Skia runtime tests, the following runtime tests are failing:
ValidateLayoutRoundingForPixelDimensions
CanReplaceSingleItem
When_CloseLast_Then_FileDeleted
Should_Close_Open_Popups
When_TransformToVisual_WithMargin
When_MinWidth_SmallerThan_AvailableSize
(fix: Workaround a lifecycle bug to allow ContentControl to be measured properly when not in visual tree #14368)TestVariousArrangedPosition
When_ProgressRing_Visible
When_Calling_Select_With_Negative_Values
When_Calling_Select_With_In_Range_Values
When_Calling_Select_With_Out_Of_Range_Length
When_Calling_Select_With_Out_Of_Range_Start
When_Nested_In_Native_View
Those tests are now ignore in order to stabilize existing passing tests.
Expected behavior
The tests pass.
How to reproduce it (as minimally and precisely as possible)
No response
Workaround
No response
Works on UWP/WinUI
No response
Environment
No response
NuGet package version(s)
3.11-dev
Affected platforms
Skia (GTK on Linux/macOS/Windows)
IDE
No response
IDE version
No response
Relevant plugins
No response
Anything else we need to know?
No response
The text was updated successfully, but these errors were encountered: