Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotReload] HR is reloading entire visual tree, instead of just the modified sub-trees #18502

Open
Xiaoy312 opened this issue Oct 17, 2024 · 0 comments
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working

Comments

@Xiaoy312
Copy link
Contributor

Current behavior

^ title

Expected behavior

^ title

How to reproduce it (as minimally and precisely as possible)

  • dotnet new install uno.templates::5.5.3 --nuget-source=... (internal feed)
  • new unoapp -n=TPHRTest -preset blank --skip-restore
  • launch the app on Desktop
  • wait until the app is fully loaded
  • set a breakpoint on MainPage.MainPage() constructor
  • from MainPage.xaml, change the only Textbox.Text to "Hello Uno HR!", and save
  • trigger Hot-Reload
  • notices the breakpoint was hit

Workaround

No response

Works on UWP/WinUI

None

Environment

Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

Uno.Templates@5.5.3 // dotnet new
Uno.Sdk@5.5.3 // global.json

Affected platforms

Skia (GTK)

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

We have also attempted replaced the Frame in App.xaml.cs with a custom MyUserControl (with both .cs and .xaml).
Hot-reloading any change on the content of MyUserControl (eg: modifying MyUserControl\Grid\ContentControl@Content), still triggers a total refresh, in which MyUserControl.ctor was called.

@Xiaoy312 Xiaoy312 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 17, 2024
@jeromelaban jeromelaban added area/hot-reload Categorizes an issue or PR as relevant to hot reload and removed triage/untriaged Indicates an issue requires triaging or verification labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hot-reload Categorizes an issue or PR as relevant to hot reload difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants