Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery][All Platform] DataGrid - The newly selected date from the calendar does not update the 'Date Planted' display box for that row. #16065

Open
sakshi173 opened this issue Mar 28, 2024 · 9 comments
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing area/date-time-pickers DatePicker, TimePicker, CalendarDatePicker... area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/all Categorizes an issue or PR as relevant to the all platforms project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries

Comments

@sakshi173
Copy link

Current behavior

Uno.Gallery.-.Google.Chrome.2024-03-28.15-45-36.mp4

Expected behavior

The changed date should display.

How to reproduce it (as minimally and precisely as possible)

  1. Launch the Uno.Gallery app for 4X or 5X version for Android.
  2. Click on “DataGrid” from the "Community Toolkit" list.
  3. Go to 'Date Planted' section
  4. Click on any existing date.
  5. Calendar should open.
  6. In the open calendar choose any date.
  7. Now click on any other part of the screen.
  8. Notice that the newly selected date from the calendar does not update the 'Date Planted' display box for that row.

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly, Android, iOS, Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@sakshi173 sakshi173 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification platform/all Categorizes an issue or PR as relevant to the all platforms area/canary 🐤 Categorizes an issue or PR as relevant to canary testing difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Mar 28, 2024
@xperiandri
Copy link
Contributor

I wonder what is this DataGrid from. Probably from Toolkit v7 as v8 does not contain a DataGrid

@morning4coffe-dev
Copy link
Member

@xperiandri Yes, this one is still from the version 7.1.2. As you said the DataGrid is currently not supported on v8+, but I think the team is currently working on a simplified DataTable - CommunityToolkit/Labs-Windows#415

@jeromelaban
Copy link
Member

@sakshi173 is the calendar showing up on the Windows version? It's very likely that it is not the case.

@sakshi173
Copy link
Author

@jeromelaban, this issue is for canary build in chrome browser for WASM and also for Android and iOS platform too, I am not sure what exactly is your question?

@jeromelaban
Copy link
Member

@sakshi173 is the behavior you're expecting found in the windows version of the gallery?

@sakshi173
Copy link
Author

@jeromelaban, okay now understood, let me check what's the functionality in Windows version.

@sakshi173
Copy link
Author

@jeromelaban , I tried to check the window version behavior for the this defect but windows version is getting crash when click on the date box. Below is the video for windows version.

WinUI.Desktop.2024-04-01.13-33-56.mp4

@Youssef1313
Copy link
Member

@jeromelaban Could it be related to the layout cycle noted in #16064 ?

i.e, our current behavior is inline with WinUI that both crashes (but when we crash we gracefully handle the exception and don't really crash the whole app)?

@jeromelaban
Copy link
Member

The fact that the windows version crashes indicates that the original code using the DataGrid is probably incorrect (either from the DataGrid itself, or from our integration from the gallery).

@MartinZikmund MartinZikmund changed the title [Gallery][All Platform]DataGrid - The newly selected date from the calendar does not update the 'Date Planted' display box for that row. [Gallery][All Platform] DataGrid - The newly selected date from the calendar does not update the 'Date Planted' display box for that row. Jul 16, 2024
@MartinZikmund MartinZikmund added area/date-time-pickers DatePicker, TimePicker, CalendarDatePicker... project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/canary 🐤 Categorizes an issue or PR as relevant to canary testing area/date-time-pickers DatePicker, TimePicker, CalendarDatePicker... area/windows-community-toolkit 🎚️ Categorizes an issue or PR as relevant to the Windows Community Toolkit difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/all Categorizes an issue or PR as relevant to the all platforms project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries
Projects
None yet
Development

No branches or pull requests

6 participants