Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure on Skia platform for ContentDialog #15981

Open
kazo0 opened this issue Mar 21, 2024 · 1 comment · May be fixed by #18261
Open

Test failure on Skia platform for ContentDialog #15981

kazo0 opened this issue Mar 21, 2024 · 1 comment · May be fixed by #18261
Assignees
@Youssef1313
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@kazo0
Copy link
Contributor

kazo0 commented Mar 21, 2024 •
edited
Loading

Current behavior

Test introduced by #15964 fails on Skia platforms

The ActualSize is still being set as the full window size rather than the overridden size that is being set in the ContentDialogPopupPanel arrange logic
@kazo0 kazo0 added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. area/tests 🧪 Categorizes an issue or PR as relevant to tests and removed kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Mar 21, 2024
@Youssef1313
Copy link
Member

The test started to fail in #18261 for Android, likely due to the same root cause of the Skia failure. Working on a fix.

@Youssef1313 Youssef1313 self-assigned this Sep 25, 2024
@Youssef1313 Youssef1313 added project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts labels Sep 25, 2024
@Youssef1313 Youssef1313 linked a pull request Sep 25, 2024 that will close this issue
Draft
6 tasks
@Youssef1313 Youssef1313 added the kind/bug Something isn't working label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/tests 🧪 Categorizes an issue or PR as relevant to tests difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix layouting on mobile unoplatform/uno
2 participants
@kazo0 @Youssef1313