Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if EVP works properly for ScrollView #15853

Open
Youssef1313 opened this issue Mar 12, 2024 · 3 comments
Open

Verify if EVP works properly for ScrollView #15853

Youssef1313 opened this issue Mar 12, 2024 · 3 comments
Assignees
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/all Categorizes an issue or PR as relevant to the all platforms

Comments

@Youssef1313
Copy link
Member

What would you like to be added

If it doesn't work, we may need to RegisterAsScrollPort, but then have to special case it in hit test as we don't want ScrollOffsets to affect HitTest (because HitTest already works correctly)

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response

@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Mar 12, 2024
@Youssef1313 Youssef1313 self-assigned this Mar 12, 2024
@Youssef1313
Copy link
Member Author

ScrollPresenter actually already calls RegisterAsScrollPort, so this is likely already working as expected. It needs tests to confirm though.

@dr1rrb
Copy link
Member

dr1rrb commented Mar 12, 2024

ScrollPresenter actually already calls RegisterAsScrollPort, so this is likely already working as expected. It needs tests to confirm though.

I would assume not with the current implementation of the "effective viewport": we rely on the internal ScrollOffsets property. We probably need either to change the effective viewport to rely on the Visual properties, either the ScrollPresenter to set our own internal property :)

@Youssef1313
Copy link
Member Author

Youssef1313 commented Mar 12, 2024

We have EffectiveViewportScrollPresenterTests that are now under #if false. These tests should be enabled and fixed :)

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI platform/all Categorizes an issue or PR as relevant to the all platforms and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request platform/all Categorizes an issue or PR as relevant to the all platforms
Projects
None yet
Development

No branches or pull requests

3 participants