Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching branches clears recent/favorite samples in Samples app #14306

Open
MartinZikmund opened this issue Nov 6, 2023 · 2 comments
Open
Labels
area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working

Comments

@MartinZikmund
Copy link
Member

Current behavior

When a new sample is created and used in a branch, and then we switch back to master, samples app will attempt to parse the recent samples list and fail as the sample type does not exist in that assembly. The same goes for favorites.

Expected behavior

The missing samples should be gracefully ignored. Even if they are lost, it should not clear the whole list (e.g. the samples available on master should remain in the list)

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia, Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Nov 6, 2023
@Norman-Lee
Copy link

Hey @MartinZikmund you mind if I pick this up? Wanna learn some C# and this feels like this might be a good starting point based on the good first issues website.

@MartinZikmund
Copy link
Member Author

MartinZikmund commented Apr 29, 2024

@Norman-Lee sure thing! The first step will be to fork uno and get the SamplesApp.Generic project to build in the Uno.UI.Skia.slnf. For intro guidance on how to contribute to Uno, check out this YouTube video, and these docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants