Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TwoPaneView has infinite height #14133

Open
morning4coffe-dev opened this issue Oct 26, 2023 · 6 comments
Open

TwoPaneView has infinite height #14133

morning4coffe-dev opened this issue Oct 26, 2023 · 6 comments
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)

Comments

@morning4coffe-dev
Copy link
Member

Current behavior

When using the TwoPaneView control with GridView I noticed my button that is supposed to be always visible is rendered on the bottom on Uno platforms which should not happen and this behavior differs from WinUI.

This is how it currently looks on Android, notice I had to scroll down to see the Button

image

Expected behavior

On Windows the Button is always visible on the screen

image

How to reproduce it (as minimally and precisely as possible)

https://github.com/morning4coffe-dev/uno-platform-testing/tree/doti/twopaneview-height

Workaround

No response

Works on UWP/WinUI

Yes

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia, Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

No response

Affected platforms

WebAssembly, Android, iOS, macOS (AppKit), Mac Catalyst, Skia (WPF), Skia (GTK on Linux/macOS/Windows), Skia (Linux Framebuffer)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@morning4coffe-dev morning4coffe-dev added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 26, 2023
@morning4coffe-dev
Copy link
Member Author

CC @MartinZikmund

@Youssef1313
Copy link
Member

Have you tested Skia/Wasm?

@Youssef1313 Youssef1313 added the project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..) label Oct 27, 2023
@morning4coffe-dev
Copy link
Member Author

@Youssef1313 Yes, the issue is very similar there, but it seems like it is even a little worse as the GridView stretches the height of its items too

@Youssef1313 Youssef1313 self-assigned this Oct 27, 2023
@Youssef1313
Copy link
Member

I just tested and it's indeed very broken on Skia. I'll investigate.

@Youssef1313
Copy link
Member

Youssef1313 commented Oct 27, 2023 •
edited
Loading

ItemsWrapGrid is actually not implemented on Skia. The issue is still reproducible on Skia with StackPanel though.

@Youssef1313 Youssef1313 mentioned this issue Oct 27, 2023
Merged
6 tasks
@Youssef1313
Copy link
Member

Skia part (not including ItemsWrapGrid support) is being done in #14147.

@Youssef1313 Youssef1313 removed their assignment Oct 27, 2023
@MartinZikmund MartinZikmund added area/listview 📃 Categorizes an issue or PR as relevant to the ListView control project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding kind/bug Something isn't working project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) project/layout 🧱 Categorizes an issue or PR as relevant to layouting and containers (Measure/Arrange, Collections,..)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @Youssef1313 @morning4coffe-dev