Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify SkiaSharp.Views.Uno correctness in nuspec files #13876

Open
Youssef1313 opened this issue Sep 30, 2023 · 0 comments
Open

Verify SkiaSharp.Views.Uno correctness in nuspec files #13876

Youssef1313 opened this issue Sep 30, 2023 · 0 comments
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries

Comments

@Youssef1313
Copy link
Member

What would you like to be added

As of writing this issue, the latest version of SkiaSharp.Views.Uno (2.88.6) supports only Xamarin TFMs for mobile platforms (e.g, MonoAndroid10 instead of net7.0-android)

Some nuspec files (e.g, lottie) declares it as a dependency for e.g, net7.0-android and net8.0-android

I think it's also questionable how this didn't fail the build:

uno/src/AddIns/Uno.UI.Svg/Uno.UI.Svg.netcoremobile.csproj

Lines 31 to 32 in 19d73f6

<PackageReference Include="SkiaSharp.Views.Uno" Condition="'$(UNO_UWP_BUILD)'=='true'" />
<PackageReference Include="SkiaSharp.Views.Uno.WinUI" Condition="'$(UNO_UWP_BUILD)'!='true'" />

Why is this needed

No response

For which platform

No response

Anything else we need to know?

No response
@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 30, 2023
@MartinZikmund MartinZikmund added project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers kind/enhancement New feature or request project/third-party 3️⃣ Categorizes an issue or PR as relevant to 3rd party libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MartinZikmund @Youssef1313