Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Skia] Tooltip location is incorrect #13795

Open
jeromelaban opened this issue Sep 25, 2023 · 6 comments
Open

[Skia] Tooltip location is incorrect #13795

jeromelaban opened this issue Sep 25, 2023 · 6 comments
Labels
area/a11y Categorizes an issue or PR as relevant to a11y area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/tooltip 💬 difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI

Comments

@jeromelaban
Copy link
Member

Sometimes I get this strange label that shows up in the left-hand corner when picking a color. I have seen this on Skia on GTK+ on Windows, and on Linux Framebuffer. Where is it coming from, and more importantly, how can I disable it? It doesn't show up all the time, I don't have a reliable way to reproduce it.

image

Originally posted by @HakanL in #13756

@jeromelaban
Copy link
Member Author

Thanks for the report. This looks like incorrect handling of pointer events, which makes the tooltip show up. You may be able to alter the template to avoid the tooltip from being available, something like this:

<Thumb x:Name="HorizontalThumb" AutomationProperties.AccessibilityView="Raw" Grid.Column="1" DataContext="{TemplateBinding Value}" Height="{ThemeResource SliderHorizontalThumbHeight}" Grid.Row="0" Grid.RowSpan="3" Style="{StaticResource SliderThumbStyle}" Width="{ThemeResource SliderHorizontalThumbWidth}">
<ToolTipService.ToolTip>
<ToolTip x:Name="ToolTip" VerticalOffset="20" />
</ToolTipService.ToolTip>

@HakanL
Copy link

HakanL commented Sep 25, 2023

Ah, that's probably what it is, I now realize it shows up most (all?) of the time when I select the brightness in the color picker. If there's anything I haven't figured out yet it's how to do style overrides with the least amount of code that doesn't mess with anything else on the color picker/thumb control, do you think you can direct me to what I need to add to my xaml to remove the tooltip?

@TopProgrammer77
Copy link
Contributor

This issue is occurred on WASM as well

@MartinZikmund MartinZikmund added the area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts label Oct 25, 2023
@MartinZikmund
Copy link
Member

You can set the Slider.IsToolTipEnabled property to false to ensure the tooltip is not shown for now, see docs

@MartinZikmund MartinZikmund added area/a11y Categorizes an issue or PR as relevant to a11y difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels Oct 25, 2023
@HakanL
Copy link

HakanL commented Oct 25, 2023

You can set the Slider.IsToolTipEnabled property to false to ensure the tooltip is not shown for now

Silly question, but how can I actually set this property to false? It's the ColorSlider control, but that isn't exposed from what I can see.

@HakanL
Copy link

HakanL commented Oct 25, 2023

FWIW I was able to get rid of the tooltip by copying the style and removing the TooltipService from the Thumb (setting any of the enable properties to False didn't do it). It would still be interesting to know how to do this in XAML without overriding the style.

@MartinZikmund MartinZikmund changed the title [Skia] Tooltip location is incorrect [Skia] Tooltip location is incorrect Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/a11y Categorizes an issue or PR as relevant to a11y area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/tooltip 💬 difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI
Projects
None yet
Development

No branches or pull requests

4 participants