Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Disable Display Size setting support #13598

Open
Soap-141 opened this issue Sep 11, 2023 · 3 comments · May be fixed by #14092
Open

[Android] Disable Display Size setting support #13598

Soap-141 opened this issue Sep 11, 2023 · 3 comments · May be fixed by #14092
Assignees
Labels
area/a11y Categorizes an issue or PR as relevant to a11y difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/text 🔤 Categorizes an issue or PR as relevant to text (TextBox, PasswordBox, TextBlock, Fonts, …)

Comments

@Soap-141
Copy link

What would you like to be added

Might not be doable, made some research on it but it would be nice if we could ignore the display size setting on Android because it can mess up the UI quit a lot.

I guess the obvious fix would be to code better XAML with less fixes sizes and less range of sizes so there is no clipping and other weird behavior but sometime we have to do some workarounds or have fixed size / range of sizes that cause more issue when playing with this setting.

Default vs Larger with font scaling disabled.

Capture_105
Capture_106

Why is this needed

A flag to disable the display size scaling.

For which platform

Android

Anything else we need to know?

No response

@Soap-141 Soap-141 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 11, 2023
@jeromelaban
Copy link
Member

Thanks for the report.

There are those two properties that should be having an effect:

public static bool IgnoreTextScaleFactor { get; set; }
#if __ANDROID__ || __IOS__
/// <summary>
/// Allows the user to limit the scale factor without having to ignore it.
/// </summary>
public static float? MaximumTextScaleFactor { get; set; }

But there may be cases where it does not apply properly.

@Soap-141
Copy link
Author

Here is my sample SampleDisplaySize.zip @ajpinedam

@MartinZikmund MartinZikmund added area/a11y Categorizes an issue or PR as relevant to a11y project/text 🔤 Categorizes an issue or PR as relevant to text (TextBox, PasswordBox, TextBlock, Fonts, …) difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 23, 2023
@MartinZikmund
Copy link
Member

I think we should both support the FeatureConfiguration properties properly, and also verify we accurately model how Windows handles text scaling based on accessibility settings:

image

@ajpinedam ajpinedam linked a pull request Oct 25, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/a11y Categorizes an issue or PR as relevant to a11y difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/text 🔤 Categorizes an issue or PR as relevant to text (TextBox, PasswordBox, TextBlock, Fonts, …)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants