[Gallery-4X and 5X][All Platform]Pipspager- Pips are displaying in white color in light theme but for windows pips displaying in dark color.

[sakshi173]

Current behavior

Expected behavior

How to reproduce it (as minimally and precisely as possible)

1. Launch the Uno.Gallery app for 4X or 5X version.
2. Click/tap Burger Menu on the left top right.
3. Ensure that the Gallery app is in Day Mode.
4. Click on “PipsPager” from the "UI Component" list.
5. Notice that pips are displaying in white color instead of dark color(similar to window version).

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly, Android, iOS, Skia (GTK on Linux/macOS/Windows)

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

[agneszitte]

@kazo0 I think we now need to have a "Material" tab + "Fluent" tab for the samples for PipsPager

[kazo0]

There seems to be an issue with muxc: specific controls here. They are not included in the XamlControlsResources dictionary so they are not overriding the implicit styles defined in Material. These styles would need to be explicitly "reset" in the App.xaml to make sure the global app style for the control is not the Material one by default

We would need to add <Style TargetType="muxc:PipsPager" /> to the App.xaml to ensure the default Fluent PipsPager style is used, along with any other TargetType="muxc:..." controls that we have Material styles for in Gallery

[jeromelaban]

Indeed, they're not in the fluent v2 dictionary: https://github.com/unoplatform/uno/tree/master/src/Uno.UI.FluentTheme.v2/Resources/Version2/PriorityDefault.

That's very curious. @MartinZikmund do you recall why that is?

[agneszitte]

Indeed, they're not in the fluent v2 dictionary: master/src/Uno.UI.FluentTheme.v2/Resources/Version2/PriorityDefault.

That's very curious. @MartinZikmund do you recall why that is?

Workaround is in place for Gallery now @kazo0 but can you open an issue for Uno please so it can be investigated/discussed?

[kazo0]

@agneszitte they also aren't there on Windows so I don't think they're supposed to be

[agneszitte]

@agneszitte they also aren't there on Windows so I don't think they're supposed to be

Hum I see, let's see if @MartinZikmund has additional comments for this (cc @jeromelaban)

[sakshi173]

@agneszitte, @kazo0 , Not sure is this fixed or not, its not getting cleared with the all the above comments.
I retested defect and still these are present for 4X and 5X. below is the screenshot.

[MartinZikmund]

@jeromelaban @kazo0 There reason here was that PipsPager and some other controls like BreadcrumbBar had no "default" style in UWP (they are WinUI 2.6 only) so I put their styles directly in Uno to avoid having to have the same style both in Uno.UI and in Uno.Fluent. Unfortunately, I did not anticipate this scenario - so the fix could be to remove the styles from Uno.UI and move them to Uno.Fluent only - which however means the user has to include XamlControlsResources to use the control in Uno targets (but this is in line with WinUI, where you need to add the styles otherwise the controls won't display anyway). What do you think?

[kazo0]

@MartinZikmund For Windows, adding this ResourceDictionary after the XamlControlsResource declaration, like we're doing here, seems to workaround this issue but it doesn't work on Uno platforms, maybe there's an Uno issue there on how it resolved the style based on TargetType?

I might be looking at old documentation but I feel like this article gives the impression that XamlControlsResources is where the WinUI 2.x+ control styles should live anyway in Uno platforms. So maybe it makes sense to move them there only then?

[jeromelaban]

Indeed, XamlControlsResources is essentially required in apps, though for uno's own tests it's not. We could have the tests that require those resources to be in the system styles to use XamlControlsResources explicitly to fix this.

[MartinZikmund]

Sounds good, will take care of this 👍