Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flyout.OverlayInputPassThroughElement does not appear to work in WASM #12681

Open
jsinsel-kahua opened this issue Jun 22, 2023 · 2 comments · Fixed by #13968
Open

Flyout.OverlayInputPassThroughElement does not appear to work in WASM #12681

jsinsel-kahua opened this issue Jun 22, 2023 · 2 comments · Fixed by #13968
Assignees
@dr1rrb
Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact.

Comments

@jsinsel-kahua
Copy link

Current behavior

Set up a button with a flyout with OverlayInputPassThroughElement set to the view. This way the user can click on another button even with the flyout open. This works in WinUI, but not in WASM.

Expected behavior

OverlayInputPassThroughElement works in WASM

How to reproduce it (as minimally and precisely as possible)

Attaching a repro.
FlyoutPassThrough.zip

Workaround

No response

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@jsinsel-kahua jsinsel-kahua added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Jun 22, 2023
@agneszitte agneszitte pinned this issue Jun 22, 2023
@agneszitte agneszitte unpinned this issue Jun 22, 2023
@ramezgerges
Copy link
Contributor

This is due to the fact that FlyoutBase.OverlayInputPassThroughElement is not implemented in Uno yet.
https://github.com/unoplatform/uno/blob/master/src/Uno.UI/Generated/3.0.0.0/Windows.UI.Xaml.Controls.Primitives/FlyoutBase.cs#L31C20

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. triage/untriaged Indicates an issue requires triaging or verification labels Jul 10, 2023
@ramezgerges ramezgerges mentioned this issue Jul 10, 2023
Closed
6 tasks
@MartinZikmund MartinZikmund changed the title Flyout.OverlayInputPassThroughElement does not appear to work in WASM Flyout.OverlayInputPassThroughElement does not appear to work in WASM Sep 19, 2023
@MartinZikmund MartinZikmund added the low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact. label Sep 19, 2023
@jeromelaban jeromelaban mentioned this issue Oct 10, 2023
Open
6 tasks
@dr1rrb dr1rrb mentioned this issue Oct 12, 2023
Merged
6 tasks
@ramezgerges
Copy link
Contributor

ramezgerges commented Apr 22, 2024 •
edited
Loading

2024-04-22.22-31-55.mp4

It seems only PointerPressed is passed through (on skia and wasm) while PointerMoved events (and others) are not. This blocks MenuBar's "cycling between menus" behaviour (see also #13918, #14290) which depends on OverlayPassthroughElement

@ramezgerges ramezgerges reopened this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr1rrb dr1rrb

Labels
area/popups 💬 Categorizes an issue or PR as relevant to popups or flyouts difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working low-hanging-🍒 Categorizes an issue that might be a quick win with meaningful positive impact.
Projects
None yet
Milestone
No milestone
4 participants
@MartinZikmund @dr1rrb @ramezgerges @jsinsel-kahua