-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate why CA1815 violations were not reported #12030
Comments
@mavasani Sorry for the ping, looking at binlog, it looks like everything is right on our end: |
@Youssef1313 Note that .globalconfig is the true replacement for ruleset files. I would generally recommend placing all of the Have you checked the value of |
@sharwell It's empty. Yeah I'm planning to move to .globalconfig, but in this case .editorconfig is supposed to just work right? |
@sharwell fyi this is still an issue with globalconfig and also updated NetAnalyzers package to |
I was able to root this down. Most classes here have an auto-generated partial. When it happens that this is the first location of a symbol, the diagnostic isn't reported because the analyzer is configured to not report on generated code. |
@Youssef1313 Weird behavior! It sounds like this is something that the .NET team should address though |
Related Roslyn issue: dotnet/roslyn#69543 |
Current behavior
There was few CA1815 violations (see #12029), but CI and local builds were green.
We already set that to error:
uno/.editorconfig
Lines 310 to 311 in bdd49d9
The text was updated successfully, but these errors were encountered: