Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding not working inside GridView #11738

Open
morning4coffe-dev opened this issue Mar 17, 2023 · 1 comment
Open

Binding not working inside GridView #11738

morning4coffe-dev opened this issue Mar 17, 2023 · 1 comment
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)

Comments

@morning4coffe-dev
Copy link
Member

Current behavior

When working on a feature for Gallery, I noticed that the when I put elements inside GridView the Binding does not work. I tested this in a new repo and I get the same issue.

image

Expected behavior

image

How to reproduce it (as minimally and precisely as possible)

https://github.com/morning4coffe-dev/uno-platform-testing/tree/doti/grid-view-binding

Workaround

No response

Works on UWP/WinUI

Yes

Environment

No response

NuGet package version(s)

No response

Affected platforms

WebAssembly, Android, iOS, macOS (AppKit), Mac Catalyst, Skia (WPF), Skia (GTK on Linux/macOS/Windows), Skia (Linux Framebuffer), Skia (Tizen)

IDE

Visual Studio 2022

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@morning4coffe-dev morning4coffe-dev added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Mar 17, 2023
@Youssef1313 Youssef1313 added the project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine label Mar 17, 2023
@jeromelaban
Copy link
Member

jeromelaban commented Mar 21, 2023 •
edited by unfurl-links bot
Loading

This is more looking like a DataContext propagation. In general, though, this particular behavior is generally not used, as DataBinding is on individual items is used. This is what likely made this issue go under the radar.

It seems to be specific to ListViewBase, as the following playground repro shows: https://playground.platform.uno/#1626a15d

@jeromelaban jeromelaban added project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) and removed project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...) project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine triage/untriaged Indicates an issue requires triaging or verification labels Mar 21, 2023
@MartinZikmund MartinZikmund added area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Sep 11, 2023
@ramezgerges ramezgerges self-assigned this Oct 17, 2023
@ramezgerges ramezgerges mentioned this issue Oct 19, 2023
Closed
6 tasks
@ramezgerges ramezgerges removed their assignment Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/listview 📃 Categorizes an issue or PR as relevant to the ListView control difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working project/binding 🪢 Categorizes an issue or PR as relevant to the binding engine project/items 🧾 Categorizes an issue or PR as relevant to items (ItemsControl, ItemsRepeater, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(listviewbase): fix DataContext propagation to Items when ItemsSource is null ramezgerges/uno
5 participants
@MartinZikmund @jeromelaban @Youssef1313 @ramezgerges @morning4coffe-dev