Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C.I.] Autogenerate ignore set as artifact in C.I. #10885

Open
1 of 13 tasks
workgroupengineering opened this issue Jan 4, 2023 · 7 comments
Open
1 of 13 tasks

[C.I.] Autogenerate ignore set as artifact in C.I. #10885

workgroupengineering opened this issue Jan 4, 2023 · 7 comments
Assignees
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request

Comments

@workgroupengineering
Copy link
Contributor

What would you like to be added:

When performing C.I. task Pack NuGet, if there are any changes on the API surface it generates ingorediff.xml

Why is this needed:

Avoid mistake in editing PackageDiffIgnore.xml, only copy and panse from ingorediff.xml to PackageDiffIgnore.xml.

For which Platform:

  • WebAssembly
  • Android
  • iOS
  • macOS (AppKit)
  • Mac Catalyst
  • Skia
    • WPF
    • GTK (Linux)
    • Linux Framebuffer
    • Tizen
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?

@workgroupengineering workgroupengineering added difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Jan 4, 2023
@Youssef1313
Copy link
Member

We could experiment with moving this check to GitHub Actions, which will comment on the PR with the necessary changes to PackageDiffIgnore

@Youssef1313 Youssef1313 added the area/build Categorizes an issue or PR as relevant to build infrastructure label Jan 4, 2023
@workgroupengineering
Copy link
Contributor Author

In this PR i have add the ability to generate Comment with changes on GitHub PR like UI Test Screenshot Comparision.

Is there a nightly feed of Uno.PackageDiff for using it in the Uno Repository?

@Youssef1313
Copy link
Member

like UI Test Screenshot Comparision

I guess that only works if the branch isn't from fork, which doesn't work for external contributors.

@jeromelaban
Copy link
Member

That's correct. Forks builds can't comment, unfortunately.

@Youssef1313
Copy link
Member

I might look into a GitHub Actions approach that works for external contributors. @workgroupengineering feel free if you wanted to look into that as well, I won't be able to look soon, so you could do it before me if you want.

@jeromelaban
Copy link
Member

At this point, the only way to handle this is to get a full build that generates all nuget packages in github actions, and there's no known link between GH actions and the Azure Devops build that are running.

@Youssef1313 Youssef1313 self-assigned this Jan 10, 2023
@workgroupengineering
Copy link
Contributor Author

GitHub Action can be trigger like this example.
We can pass PRid, baseVersion , CurrentVersion and BuildId as payload, through which we can build the url of the artifact to download and then perform the comparison.

@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. area/automation Categorizes an issue or PR as relevant to project automation and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure area/contributor-experience Categorizes an issue or PR as relevant to contributor experience. difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants