From 43620a6f6954e2705bf3dce07ebd64de980b22fa Mon Sep 17 00:00:00 2001 From: Andres Pineda Date: Thu, 1 Jun 2023 00:17:29 -0400 Subject: [PATCH] chore(Droid): enable nullable Drawabler Helpers --- src/Uno.UI/DrawableHelper.Android.cs | 5 +++-- src/Uno.UWP/Helpers/DrawableHelper.Android.cs | 15 ++++++++------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/Uno.UI/DrawableHelper.Android.cs b/src/Uno.UI/DrawableHelper.Android.cs index 062613fdc218..89d6f49b7a48 100644 --- a/src/Uno.UI/DrawableHelper.Android.cs +++ b/src/Uno.UI/DrawableHelper.Android.cs @@ -1,4 +1,5 @@ -using Android.Graphics.Drawables; +#nullable enable +using Android.Graphics.Drawables; using System; using System.ComponentModel; using Windows.UI.Xaml.Media; @@ -14,7 +15,7 @@ public static class DrawableHelper /// /// URI /// Drawable - public static Drawable FromUri(Uri uri) => + public static Drawable? FromUri(Uri uri) => Uno.Helpers.DrawableHelper.FromUri(uri); } } diff --git a/src/Uno.UWP/Helpers/DrawableHelper.Android.cs b/src/Uno.UWP/Helpers/DrawableHelper.Android.cs index 04bde9eaa5a7..88f9f84b38a5 100644 --- a/src/Uno.UWP/Helpers/DrawableHelper.Android.cs +++ b/src/Uno.UWP/Helpers/DrawableHelper.Android.cs @@ -1,3 +1,4 @@ +#nullable enable using Android.Graphics.Drawables; using AndroidX.Core.Content; using AndroidX.Core.Graphics.Drawable; @@ -13,12 +14,12 @@ namespace Uno.Helpers { public static class DrawableHelper { - private static Dictionary _drawablesLookup; - private static Type _drawables; + private static Dictionary? _drawablesLookup; + private static Type? _drawables; - private static Func _resolver; + private static Func? _resolver; - public static Type Drawables + public static Type? Drawables { get => _drawables; set @@ -83,8 +84,8 @@ public static Type Drawables /// Finds a Drawable by URI /// /// Uri - /// Drawable - public static Drawable FromUri(Uri uri) + /// for the URI provided or null otherwise + public static Drawable? FromUri(Uri uri) { var id = FindResourceIdFromPath(uri.PathAndQuery.TrimStart(new[] { '/' })); var drawable = id.HasValue @@ -109,7 +110,7 @@ public static Drawable FromUri(Uri uri) private static void InitializeDrawablesLookup() { _drawablesLookup = _drawables - .GetFields(BindingFlags.Static | BindingFlags.Public) + ?.GetFields(BindingFlags.Static | BindingFlags.Public) .ToDictionary( p => p.Name, p => (int)p.GetValue(null)