Skip to content

Commit 6394e18

Browse files
Cleanup the PR for fixing build (xamarin#871)
* Cleanup the PR for fixing build * Fix the info
1 parent f6aaf2a commit 6394e18

File tree

4 files changed

+16
-13
lines changed

4 files changed

+16
-13
lines changed

DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="MSBuild.Sdk.Extras/2.0.29">
1+
<Project Sdk="MSBuild.Sdk.Extras/2.0.31">
22
<PropertyGroup>
33
<!--Work around so the conditions work below-->
44
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">Xamarin.iOS10;MonoAndroid90;uap10.0.16299</TargetFrameworks>

DeviceTests/build.cake

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
var TARGET = Argument("target", "Default");
77

88
var IOS_SIM_NAME = EnvironmentVariable("IOS_SIM_NAME") ?? "iPhone X";
9-
var IOS_SIM_RUNTIME = EnvironmentVariable("IOS_SIM_RUNTIME") ?? "iOS 12.0";
9+
var IOS_SIM_RUNTIME = EnvironmentVariable("IOS_SIM_RUNTIME") ?? "iOS 12.2";
1010
var IOS_PROJ = "./DeviceTests.iOS/DeviceTests.iOS.csproj";
1111
var IOS_BUNDLE_ID = "com.xamarin.essentials.devicetests";
1212
var IOS_IPA_PATH = "./DeviceTests.iOS/bin/iPhoneSimulator/Release/XamarinEssentialsDeviceTestsiOS.app";
@@ -106,11 +106,14 @@ Task ("test-ios-emu")
106106
.IsDependentOn ("build-ios")
107107
.Does (() =>
108108
{
109+
var sims = ListAppleSimulators ();
110+
foreach (var s in sims)
111+
{
112+
Information("Info: {0} ({1} - {2} - {3})", s.Name, s.Runtime, s.UDID, s.Availability);
113+
}
114+
109115
// Look for a matching simulator on the system
110-
var sim = ListAppleSimulators ()
111-
.First (s => (s.Availability.Contains("available") || s.Availability.Contains("booted"))
112-
&& !s.Availability.Contains("unavailable")
113-
&& s.Name == IOS_SIM_NAME && s.Runtime == IOS_SIM_RUNTIME);
116+
var sim = sims.First (s => s.Name == IOS_SIM_NAME && s.Runtime == IOS_SIM_RUNTIME);
114117

115118
// Boot the simulator
116119
Information("Booting: {0} ({1} - {2})", sim.Name, sim.Runtime, sim.UDID);

Xamarin.Essentials/Xamarin.Essentials.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<Project Sdk="MSBuild.Sdk.Extras/2.0.29">
1+
<Project Sdk="MSBuild.Sdk.Extras/2.0.31">
22
<PropertyGroup>
33
<TargetFrameworks Condition=" '$(OS)' == 'Windows_NT' ">netstandard1.0;netstandard2.0;Xamarin.iOS10;MonoAndroid60;MonoAndroid70;MonoAndroid71;MonoAndroid80;MonoAndroid81;MonoAndroid90;uap10.0.16299</TargetFrameworks>
44
<TargetFrameworks Condition=" '$(OS)' != 'Windows_NT' ">netstandard1.0;netstandard2.0;Xamarin.iOS10;MonoAndroid60;MonoAndroid70;MonoAndroid71;MonoAndroid80;MonoAndroid81;MonoAndroid90;</TargetFrameworks>

azure-pipelines.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ variables:
33
CurrentSemanticVersionBase: '1.0.0'
44
CurrentSemanticVersion: '$(CurrentSemanticVersionBase)-preview$(Build.BuildNumber)'
55
NugetPackageVersion: '$(CurrentSemanticVersion)'
6-
MONO_VERSION: 5_16_0
7-
XCODE_VERSION: 10.1
6+
MONO_VERSION: 5_18_1
7+
XCODE_VERSION: 10.2.1
88
IOS_SIM_NAME: 'iPhone X'
9-
IOS_SIM_RUNTIME: 'iOS 12.1'
9+
IOS_SIM_RUNTIME: 'com.apple.CoreSimulator.SimRuntime.iOS-12-2'
1010
ANDROID_EMU_TARGET: 'system-images;android-26;google_apis;x86'
1111
ANDROID_EMU_DEVICE: 'Nexus 5X'
1212
RunPoliCheck: 'false'
@@ -76,7 +76,7 @@ jobs:
7676
- job: build_macos
7777
displayName: Build macOS Library
7878
pool:
79-
vmImage: macos-10.13
79+
vmImage: macos-10.14
8080
steps:
8181
# if this is a tagged build, then update the version number
8282
- powershell: |
@@ -152,7 +152,7 @@ jobs:
152152
- build_windows
153153
- build_macos
154154
pool:
155-
vmImage: macos-10.13
155+
vmImage: macos-10.14
156156
steps:
157157
- bash: sudo $AGENT_HOMEDIRECTORY/scripts/select-xamarin-sdk.sh $(MONO_VERSION)
158158
displayName: Switch to the latest Xamarin SDK
@@ -183,7 +183,7 @@ jobs:
183183
- build_windows
184184
- build_macos
185185
pool:
186-
vmImage: macos-10.13
186+
vmImage: macos-10.14
187187
steps:
188188
- bash: sudo $AGENT_HOMEDIRECTORY/scripts/select-xamarin-sdk.sh $(MONO_VERSION)
189189
displayName: Switch to the latest Xamarin SDK

0 commit comments

Comments
 (0)