Skip to content

fix(query): use Object.create(null) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

fix(query): use Object.create(null) #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9c925f
fix(query): use `Object.create(null)`
pi0 Apr 8, 2025
936c3b7
keep comments
pi0 Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ export type QueryObject = Record<string, QueryValue | QueryValue[]>;

export type ParsedQuery = Record<string, string | string[]>;

const EmptyObject = /* @__PURE__ */ (() => {
const C = function () {};
C.prototype = Object.create(null);
return C;
})() as unknown as { new (): any };
// const EmptyObject = /* @__PURE__ */ (() => {
// const C = function () {};
// C.prototype = Object.create(null);
// return C;
// })() as unknown as { new (): any };

/**
* Parses and decodes a query string into an object.
Expand All @@ -37,7 +37,9 @@ const EmptyObject = /* @__PURE__ */ (() => {
export function parseQuery<T extends ParsedQuery = ParsedQuery>(
parametersString = "",
): T {
const object: ParsedQuery = new EmptyObject();
// TODO: Use new EmptyObject() instead of Object.create(null) for better performance in next major version
// https://github.com/unjs/ufo/pull/290
const object: ParsedQuery = Object.create(null);
if (parametersString[0] === "?") {
parametersString = parametersString.slice(1);
}
Expand Down