more standard casting procedure

Author: unixpickle

vector32.go

@@ -46,10 +46,11 @@ func (v *vector32) SetData(d anyvec.NumericList) {
 	})
 }
 
-func (v *vector32) Set(v1 anyvec.Vector) {
+func (v *vector32) Set(other anyvec.Vector) {
+	v1 := other.(*vector32)
 	v.assertCompat(v1, false)
 	v.run(func() error {
-		buf1 := v1.(*vector32).buffer
+		buf1 := v1.buffer
 		if buf1 == nil {
 			if v.buffer != nil {
 				return cuda.ClearBuffer(v.buffer)
@@ -89,16 +90,16 @@ func (v *vector32) Slice(start, end int) anyvec.Vector {
 	return res
 }
 
-func (v *vector32) SetSlice(start int, v1 anyvec.Vector) {
-	src := v1.(*vector32)
-	if src.Len() > v.Len()-start {
+func (v *vector32) SetSlice(start int, other anyvec.Vector) {
+	v1 := other.(*vector32)
+	if v1.Len() > v.Len()-start {
 		panic("index out of range")
-	} else if start <= -src.Len() {
+	} else if start <= -v1.Len() {
 		return
 	}
 
 	v.run(func() error {
-		if src.buffer == nil && v.buffer == nil {
+		if v.buffer == nil && v1.buffer == nil {
 			return nil
 		}
 		dstStart := start
@@ -107,7 +108,7 @@ func (v *vector32) SetSlice(start int, v1 anyvec.Vector) {
 			dstStart = 0
 			srcStart = -start
 		}
-		copyCount := src.Len() - srcStart
+		copyCount := v1.Len() - srcStart
 		if v.Len()-dstStart < copyCount {
 			copyCount = v.Len() - dstStart
 		}
@@ -116,10 +117,10 @@ func (v *vector32) SetSlice(start int, v1 anyvec.Vector) {
 		}
 		dst := cuda.Slice(v.buffer, uintptr(dstStart)*4,
 			uintptr(dstStart+copyCount)*4)
-		if src.buffer == nil {
+		if v1.buffer == nil {
 			return cuda.ClearBuffer(dst)
 		}
-		srcSlice := cuda.Slice(src.buffer, uintptr(srcStart)*4,
+		srcSlice := cuda.Slice(v1.buffer, uintptr(srcStart)*4,
 			uintptr(srcStart+copyCount)*4)
 		return cuda.CopyBuffer(dst, srcSlice)
 	})
@@ -139,42 +140,43 @@ func (v *vector32) AddScaler(s anyvec.Numeric) {
 	panic("nyi")
 }
 
-func (v *vector32) Dot(v1 anyvec.Vector) anyvec.Numeric {
+func (v *vector32) Dot(other anyvec.Vector) anyvec.Numeric {
+	v1 := other.(*vector32)
 	v.assertCompat(v1, true)
 	var res float32
 	v.runSync(func() error {
-		v32 := v1.(*vector32)
-		if err := lazyInitAll(true, v, v32); err != nil {
+		if err := lazyInitAll(true, v, v1); err != nil {
 			return err
 		}
-		return v.creator.Handle.blas.Sdot(v.Len(), v.buffer, 1, v32.buffer, 1, &res)
+		return v.creator.Handle.blas.Sdot(v.Len(), v.buffer, 1, v1.buffer, 1, &res)
 	})
 	return res
 }
 
-func (v *vector32) Add(v1 anyvec.Vector) {
-	v.axpy(1, v1)
+func (v *vector32) Add(other anyvec.Vector) {
+	v.axpy(1, other.(*vector32))
 }
 
-func (v *vector32) Sub(v1 anyvec.Vector) {
-	v.axpy(-1, v1)
+func (v *vector32) Sub(other anyvec.Vector) {
+	v.axpy(-1, other.(*vector32))
 }
 
-func (v *vector32) Mul(v1 anyvec.Vector) {
+func (v *vector32) Mul(other anyvec.Vector) {
+	v1 := other.(*vector32)
 	v.assertCompat(v1, false)
 	panic("nyi")
 }
 
-func (v *vector32) Div(v1 anyvec.Vector) {
+func (v *vector32) Div(other anyvec.Vector) {
+	v1 := other.(*vector32)
 	v.assertCompat(v1, false)
-	v132 := v1.(*vector32)
 	v.run(func() error {
-		if err := lazyInitAll(true, v, v132); err != nil {
+		if err := lazyInitAll(true, v, v1); err != nil {
 			return err
 		}
 		grid, block := v.kernelSizes()
 		return v.creator.Handle.kernels32.Launch("kernel", grid, 1, 1,
-			block, 1, 1, 0, v.buffer, v132.buffer, v.Len())
+			block, 1, 1, 0, v.buffer, v1.buffer, v.Len())
 	})
 }
 
@@ -206,25 +208,24 @@ func (v *vector32) Gemm(transA, transB bool, m, n, k int,
 	})
 }
 
-func (v *vector32) axpy(scaler float32, v1 anyvec.Vector) {
+func (v *vector32) axpy(scaler float32, v1 *vector32) {
 	v.assertCompat(v1, false)
-	v32 := v1.(*vector32)
 	v.run(func() error {
-		if v32.buffer == nil {
+		if v1.buffer == nil {
 			return nil
 		} else if v.buffer == nil {
 			if err := v.lazyInit(false); err != nil {
 				return err
 			}
-			if err := cuda.CopyBuffer(v.buffer, v32.buffer); err != nil {
+			if err := cuda.CopyBuffer(v.buffer, v1.buffer); err != nil {
 				return err
 			}
 			if scaler == 1 {
 				return nil
 			}
 			return v.creator.Handle.blas.Sscal(v.Len(), scaler, v.buffer, 1)
 		}
-		return v.creator.Handle.blas.Saxpy(v.Len(), scaler, v32.buffer, 1,
+		return v.creator.Handle.blas.Saxpy(v.Len(), scaler, v1.buffer, 1,
 			v.buffer, 1)
 	})
 }
@@ -252,11 +253,10 @@ func (v *vector32) lazyInit(clear bool) error {
 	return nil
 }
 
-func (v *vector32) assertCompat(v1 anyvec.Vector, readOnly bool) {
-	v132 := v1.(*vector32)
-	if readOnly || v == v132 {
+func (v *vector32) assertCompat(v1 *vector32, readOnly bool) {
+	if readOnly || v == v1 {
 		panic("vectors cannot be equal")
-	} else if v.Len() != v132.Len() {
+	} else if v.Len() != v1.Len() {
 		panic("length mismatch")
 	}
 }