Adding simple STI support test

Author: Emmanuel Delgado

lib/rails3-jquery-autocomplete/helpers.rb

@@ -19,9 +19,10 @@ def get_object(model_sym)
     # Returns a symbol representing what implementation should be used to query
     # the database and raises *NotImplementedError* if ORM implementor can not be found
     def get_implementation(object) 
-      if object.ancestors.collect(&:to_s).include?('ActiveRecord::Base')
+      ancestors_ary = object.ancestors.collect(&:to_s)
+      if ancestors_ary.include?('ActiveRecord::Base')
         :activerecord
-      elsif object.ancestors.collect(&:to_s).include?('Mongoid::Document')
+      elsif ancestors_ary.include?('Mongoid::Document')
         :mongoid
       else
         raise NotImplementedError

test/active_record_test.rb

@@ -0,0 +1,36 @@
+require "test_helper"
+require 'test_controller'
+require 'support/mongoid'
+require 'support/active_record'
+
+class ActiveRecordControllerTest < ActionController::TestCase
+  include Rails3JQueryAutocomplete::TestCase::ActiveRecord
+  include Rails3JQueryAutocomplete::TestCase
+end
+
+class ActiveRecordSTIControllerTest < ActionController::TestCase
+  require 'support/active_record'
+  include Rails3JQueryAutocomplete::TestCase::ActiveRecord
+  include Rails3JQueryAutocomplete::TestCase
+
+  def create_models
+    @parent_movie_class = Object.const_set(:Movie, Class.new(::ActiveRecord::Base))
+    @parent_movie_class.class_eval do
+      def display_name
+        "Movie: #{name}"
+      end
+    end
+    @movie_class = Object.const_set(:HorrorMovie, Class.new(@parent_movie_class))
+  end
+
+  def destroy_models
+    Object.send(:remove_const, :Movie)
+    Object.send(:remove_const, :HorrorMovie)
+  end
+
+end
+
+class MonogidControllerTest < ActionController::TestCase
+  include Rails3JQueryAutocomplete::TestCase::Mongoid
+  include Rails3JQueryAutocomplete::TestCase
+end

test/implementations_test.rb

@@ -1,43 +1,44 @@
 module Rails3JQueryAutocomplete
-  module Test
-    module Setup
+  module TestCase
+    module ActiveRecord
       def setup
         ::ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
         ::ActiveRecord::Schema.define(:version => 1) do
           create_table :movies do |t|
             t.column :name, :string
           end
-
-          create_table :actors do |t|
-            t.column :movie_id, :integer
-            t.column :name, :string
-          end
         end
 
-        @actor_class = Object.const_set(:Actor, Class.new(::ActiveRecord::Base))
-        @actor_class.belongs_to(:movie)
-
-        @movie_class = Object.const_set(:Movie, Class.new(::ActiveRecord::Base))
-        @movie_class.class_eval do
-          def display_name
-            "Movie: #{name}"
-          end
-        end
+        create_models
 
         @controller = ActorsController.new
 
-        @movie1  = @movie_class.create(:name => 'Alpha')
+        @movie1 = @movie_class.create(:name => 'Alpha')
         @movie2 = @movie_class.create(:name => 'Alspha')
         @movie3 = @movie_class.create(:name => 'Alzpha')
       end
 
       def teardown
-        Object.send(:remove_const, :Actor)
-        Object.send(:remove_const, :Movie)
+        destroy_models
         ::ActiveRecord::Base.connection.tables.each do |table|
           ::ActiveRecord::Base.connection.drop_table(table)
         end
       end
+
+      private
+      def create_models
+        @movie_class = Object.const_set(:Movie, Class.new(::ActiveRecord::Base))
+        @movie_class.class_eval do
+          def display_name
+            "Movie: #{name}"
+          end
+        end
+      end
+
+      def destroy_models
+        Object.send(:remove_const, :Movie)
+      end
+
     end
   end
 end

test/mongoid_test.rb

@@ -1,6 +1,6 @@
 module Rails3JQueryAutocomplete
-  module Test
-    class ActorsControllerTest
+  module TestCase
+    module Mongoid
       def setup
         ::Mongoid.configure do |config|
           name = "rails3_jquery_autocomplete_test"
@@ -9,6 +9,22 @@ def setup
           config.logger = nil
         end
 
+        create_models 
+
+        @controller = ActorsController.new
+
+        @movie1 = @movie_class.create(:name => 'Alpha')
+        @movie2 = @movie_class.create(:name => 'Alspha')
+        @movie3 = @movie_class.create(:name => 'Alzpha')
+      end
+
+      def teardown
+        destroy_models
+        ::Mongoid.master.collections.select {|c| c.name !~ /system/ }.each(&:drop)
+      end
+
+      private
+      def create_models
         @movie_class = Object.const_set(:Movie, Class.new)
         @movie_class.send(:include, ::Mongoid::Document)
         @movie_class.field(:name, :class => String)
@@ -17,18 +33,12 @@ def display_name
             "Movie: #{name}"
           end
         end
-
-        @controller = ActorsController.new
-
-        @movie1  = @movie_class.create(:name => 'Alpha')
-        @movie2 = @movie_class.create(:name => 'Alspha')
-        @movie3 = @movie_class.create(:name => 'Alzpha')
       end
 
-      def teardown
+      def destroy_models
         Object.send(:remove_const, :Movie)          
-        ::Mongoid.master.collections.select {|c| c.name !~ /system/ }.each(&:drop)
       end
+
     end
   end
 end

test/support/active_record.rb

@@ -1,5 +1,5 @@
 module Rails3JQueryAutocomplete
-  module Test
+  module TestCase
 
     include Shoulda::InstanceMethods
     extend Shoulda::ClassMethods