Skip to content

fix: version update + changelog via PR #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Oct 9, 2023
Merged

fix: version update + changelog via PR #252

merged 20 commits into from
Oct 9, 2023

Conversation

wphyojpl
Copy link
Collaborator

@wphyojpl wphyojpl commented Oct 3, 2023

  • last idea did not work as develop branch is protected.
  • I did find a way to commit it via creating a PR and merging it automatically.
  • People don't recommend it as others can use it to merge bad code.
  • So, I stopped it at creating a PR.
  • The new flow is:
  • create a feature PR w/o version update or changelog.
  • After merging, it will create another PR with updated version and changelog.
  • It can be briefly reviewed to see no other changes, and merge it.

wphyojpl and others added 20 commits October 2, 2023 12:12
@wphyojpl
chore: dummy commit (#226)
d6b8a5b
@wphyojpl
fix: GitHub action write protected branch (#227)
c625a90 
* chore: dummy commit

* fix: protected-branch error
@wphyojpl
fix: GitHub action write protected branch 2 (#228)
d515835 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version
@wphyojpl
fix: GitHub action write protected branch 3 (#229)
0f89009 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script
@wphyojpl
chore: reset readme
a99fdc7
@wphyojpl
fix: GitHub action write protected branch 4 (#230)
75d04d1 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV
@wphyojpl
fix: GitHub action write protected branch 5 (#231)
b8d9c2b 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes
@wphyojpl
fix: GitHub action write protected branch 6 (#232)
1e2b4c9 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging
@wphyojpl
fix: GitHub action write protected branch 7 (#233)
e6fee93 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit
@wphyojpl
chore: update version + change log
f72a063
@wphyojpl
feat: create PR
133bdfd
@wphyojpl
chore: update version + change log (#239)
9ec12ed 
* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log
@wphyojpl
chore: update version + change log (#240)
423fe04 
* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log
@wphyojpl
fix: GitHub action write protected branch 10 (#241)
dc73b6f 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log
@wphyojpl
fix: GitHub action write protected branch 11 (#242)
709e33d 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* fix: adding GH_token

* fix; displaying env for debug
@wphyojpl
fix GitHub action write protected branch 12 (#244)
3f230a0 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* fix: adding GH_token

* fix; displaying env for debug

* fix: adding log statements
@wphyojpl
fix: GitHub action write protected branch 14 (#246)
2503329 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* fix: adding GH_token

* fix; displaying env for debug

* fix: adding log statements
@wphyojpl
fix: GitHub action write protected branch 15 (#248)
239f2e5 
* chore: dummy commit

* fix: protected-branch error

* fix: wrong version

* fix: using pat token + shell script

* fix: checking ENV

* fix: revert some changes

* fix: still debugging

* chore: dummy commit

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* chore: update version + change log

* fix: adding GH_token

* fix; displaying env for debug

* fix: adding log statements

* fix: not allowing auto merge

* fix: dummy commit
@github-actions @wphyojpl
chore: update version + change log (#249)
ac20fc2 
Co-authored-by: wphyojpl <wai.phyo@jpl.nasa.gov>
@github-actions @wphyojpl
chore: update version + change log (#250)
be1043a 
Co-authored-by: wphyojpl <wai.phyo@jpl.nasa.gov>
@wphyojpl wphyojpl requested a review from ngachung October 3, 2023 01:06
@wphyojpl wphyojpl merged commit 402f2f4 into develop Oct 9, 2023
@wphyojpl wphyojpl deleted the develop-2023-10-02 branch October 9, 2023 18:32
@ngachung ngachung mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngachung ngachung ngachung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wphyojpl @ngachung