This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Add (and style) the basic Catalog page layout #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hojberg
force-pushed
the
basic-catalog-layout
branch
from
27026b0 to
e86ada3
Compare
* To support the Catalog page, add a unison-share css folder for the catalog page and a new Card module for cards holding each category in the catalog. * Rename `UI.Page` to `UI.PageLayout` to better communicate what that module is for. * Add a way to generate a Route from a Project (exclusively to the Unison Share target) to allow clicking to through to the project page from the catalog
hojberg
force-pushed
the
basic-catalog-layout
branch
from
e86ada3 to
c2b9f8c
Compare
hojberg
commented
Dec 14, 2021
| @@ -1,26 +1,33 @@ | |||
| module UnisonShare.Page.Catalog exposing (..) | |||
|
|
|||
| import Api | |||
| import Dict exposing (Dict) | |||
| -- import Api | |||
There was a problem hiding this comment.
Disabled to satisfy linter - will make it back as we start to load real data.
hojberg
commented
Dec 14, 2021
| Success | ||
| { catalog = Catalog categories | ||
| , query = "" | ||
| } | ||
| in |
There was a problem hiding this comment.
Mocking a Success respinse.
hojberg
commented
Dec 14, 2021
| fqn = | ||
| FQN.cons (Project.ownerToString project_.owner) project_.name | ||
| in | ||
| Perspective (Perspective.ByNamespace Relative fqn) |
There was a problem hiding this comment.
Perspectives make less and less sense for Unison Share. This will need some rework.
hojberg
commented
Dec 14, 2021
| @@ -10,13 +9,18 @@ type Owner | |||
|
|
|||
|
|
|||
| type alias Project a = | |||
| { a | owner : Owner, name : FQN, hash : Hash } | |||
| { a | owner : Owner, name : FQN } | |||
There was a problem hiding this comment.
Remove the Hash field for now to make it easier to mock (creating a Hash returns a Maybe)—it'll be back in a later iteration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to render a catalog page (#144)
Solution
(this screenshot is the current look, but needs more work in terms of hero background and input focus)
UI.PagetoUI.PageLayoutto better communicate what that module is for.Caveats/Notes
There's a bunch of hardcoded mock data that'll be removed when we load this from the server for real (empty categories are not expected to show up on the final page).