This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Ensure Definitions are opened via Route changes #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the URL to be main way definitions are opened and fetched. Previously this was an afterthought such that we fetched a definition and then changed the URL, resulting in broken back-button behavior. This changes how we load definitions such that a URL is changed which, in a route handler, causes the Workspace to open and fetch that definition, with 1 exception: when a definition is opened from another definition, it is important that we open the new definition relative to the originating definition (above it or below it). In this case we open the definition, then change the URL, which subsequently tries to open the definition again; seeing that the definition has been opened already the fetch attempt is cancelled.
hojberg
force-pushed
the
route-driven-open-definitions
branch
from
494fc12 to
7bd3f81
Compare
hojberg
commented
Nov 30, 2021
| in | ||
| ( { model | route = route, workspace = workspace }, Cmd.map WorkspaceMsg cmd ) | ||
|
|
||
| _ -> |
There was a problem hiding this comment.
This doesn't attempt to fix route driven perspectives (later effort).
hojberg
commented
Nov 30, 2021
| @@ -116,7 +116,7 @@ update env msg ({ workspaceItems } as model) = | |||
| in | |||
| ( { model | workspaceItems = nextWorkspaceItems } | |||
| , cmd | |||
| , openDefinitionsFocusToOutMsg nextWorkspaceItems | |||
| , None | |||
There was a problem hiding this comment.
(this is the FetchItemFinished pattern match)
We don't need to change the URL to the focused item after fetching anymore since we are now fetching what was in the URL.
pchiusano
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want the URL to be main way definitions are opened and fetched.
Previously this was an afterthought such that we fetched a definition
and then changed the URL, resulting in broken back-button behavior.
Solution
This changes how we load definitions such that a URL is changed which,
in a route handler, causes the Workspace to open and fetch that
definition, with 1 exception: when a definition is opened from another
definition, it is important that we open the new definition relative to the
originating definition (above it or below it). In this case we open the
definition, then change the URL, which subsequently tries to open the
definition again; seeing that the definition has been opened already the
fetch attempt is cancelled.
Fixes #236 and part of #195 (back button still does not work for perspectives)