This repository was archived by the owner on Jul 19, 2022. It is now read-only.
Organize the routing model to favor "latest" #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that we use Relative everywhere and disable Absolute URLs until we are ready to support them. Add comments to communicate why this is done (Share doesn't support history) and change PreApp to fetch the perspective information from Api.codebaseHash instead of Api.list (so we can limit Api to only use Perspective instead of PerspectiveParams).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ensure that we use Relative everywhere and disable Absolute URLs until we are ready to support them.
Closes #242
Implementation notes
Add comments to communicate why this is done (Share doesn't support history) and change PreApp to fetch the perspective information from Api.codebaseHash instead of Api.list (so we can limit Api to only use Perspective instead of PerspectiveParams).
Loose ends
Down the line (when Share again supports historic codebases), we should design a "permalink" like feature for absolute urls similar to what we see on GitHub.