Crop long definition docs #237
Conversation
When definition docs are very long (and the term isn't a doc itself), crop the doc and provide an affordance to show the full doc. To determine if the doc is very long, render it in an `overflow: hidden` container and query the dom to see if that container has content that is cropped.
|
Somehow I'm not loving the visual treatment. The button part looks good, but the line and gradient doesn't quite give me a sense of "this continues on". I think this treatment is better, from Slack's snippet preview. On hover it has a "click to expand".
|
|
@pchiusano my example isn't great, but there is an overlapping gradient like in slacks example, the way this example is cut doesn't show that. It would be like if slack cut at line 4. I don't like the "hover to show button bit that much, but I can probably extend the gradient to make it more obvious though. |
|
Yeah, I dunno about the hover either. One note - in the Slack treatment, the gradient is white, giving me an impression that the content of the snippet is fading away toward the bottom. |
|
@pchiusano how's this? |
|
Amazing! This is much better. |
Overview
When definition docs are very long (and the definition isn't a doc itself), crop the doc and provide an affordance to show the full doc.
Closes #187
Implementation notes
To determine if the doc is very long, render it in an
overflow: hiddencontainer and query the dom to see if that container has content that is
cropped.