This repository was archived by the owner on Jul 19, 2022. It is now read-only.
FQN: Add support for special characters #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support special characters in FQNs like "." and "/" and correctly parse them from the URL using URL encoding and a special Unison specific encoding with ";." for ".". * Also update the namespace/definition url separator from "/-/" to "/;/". * Add a bunch of parser test coverage.
hojberg
commented
Aug 16, 2021
| go z | ||
|
|
||
| x :: y -> | ||
| x :: go y |
There was a problem hiding this comment.
Adapted from the Haskell implementation
hojberg
commented
Aug 16, 2021
| urlDecode s = | ||
| -- Let invalid % encoding fall through, since it then must be valid | ||
| -- strings | ||
| Maybe.withDefault s (Url.percentDecode s) |
There was a problem hiding this comment.
percentDecode seems a bit strange to me in that it fails if it encounters a % not followed by valid encoding characters. That kind of configuration are still valid URLs though.
hojberg
commented
Aug 16, 2021
| @@ -161,7 +161,7 @@ hashQualifiedFromString sep str = | |||
|
|
|||
| name_ :: unprefixedHash :: [] -> | |||
| Hash.fromString (Hash.prefix ++ unprefixedHash) | |||
| |> Maybe.map (HashQualified (FQN.fromString name_)) | |||
| |> Maybe.map (HashQualified (toFQN name_)) | |||
There was a problem hiding this comment.
This was a bug; we were never passing this through a URL encoder.
hojberg
commented
Aug 16, 2021
| -- ';' as the separator character between namespace FQNs and | ||
| -- definition FQNs. (';' is not a valid character in FQNs and is | ||
| -- safe as a separator/escape character). | ||
| [ b (succeed (identity ".") |. s ";.") |
There was a problem hiding this comment.
Having this special case here didn't feel great, but was the simplest when chomping deals with character to character which would lead to a clash with /;/ (the namespace/definition separator).
|
@pchiusano when you have a moment, i'd love your eyes on this :) |
pchiusano
approved these changes
Aug 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
"."and"/"and correctly parsethem from the URL using URL encoding and a special Unison specific
encoding with
";."for"."."/-/"to"/;/".This fixes #196