Skip to content

Commit 47694c6

Browse files
committed
Refactor code-style
1 parent 785acef commit 47694c6

File tree

6 files changed

+245
-229
lines changed

6 files changed

+245
-229
lines changed

.prettierignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
coverage/

index.js

Lines changed: 79 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -1,146 +1,153 @@
1-
'use strict';
1+
'use strict'
22

3-
var path = require('path');
4-
var gitDiffTree = require('git-diff-tree');
5-
var findUp = require('vfile-find-up');
3+
var path = require('path')
4+
var gitDiffTree = require('git-diff-tree')
5+
var findUp = require('vfile-find-up')
66

7-
module.exports = diff;
7+
module.exports = diff
88

9-
var own = {}.hasOwnProperty;
9+
var own = {}.hasOwnProperty
1010

11-
var previousRange;
11+
var previousRange
1212

1313
function diff() {
14-
var cache = {};
14+
var cache = {}
1515

16-
return transform;
16+
return transform
1717

1818
function transform(tree, file, next) {
19-
var base = file.dirname;
20-
var commitRange = process.env.TRAVIS_COMMIT_RANGE;
21-
var range = (commitRange || '').split(/\.{3}/);
19+
var base = file.dirname
20+
var commitRange = process.env.TRAVIS_COMMIT_RANGE
21+
var range = (commitRange || '').split(/\.{3}/)
2222

2323
if (!base || !commitRange || range.length !== 2) {
24-
return next();
24+
return next()
2525
}
2626

2727
if (commitRange !== previousRange) {
28-
cache = {};
29-
previousRange = commitRange;
28+
cache = {}
29+
previousRange = commitRange
3030
}
3131

3232
if (own.call(cache, base)) {
33-
tick(cache[base]);
33+
tick(cache[base])
3434
} else {
35-
findUp.one('.git', file.dirname, function (err, git) {
36-
/* istanbul ignore if - never happens */
37-
if (err) {
38-
return next(err);
39-
}
35+
findUp.one('.git', file.dirname, ongit)
36+
}
4037

41-
/* istanbul ignore if - not testable in a Git repo... */
42-
if (!git) {
43-
return next(new Error('Not in a git repository'));
44-
}
38+
function ongit(err, git) {
39+
/* istanbul ignore if - never happens */
40+
if (err) {
41+
return next(err)
42+
}
43+
44+
/* istanbul ignore if - not testable in a Git repo... */
45+
if (!git) {
46+
return next(new Error('Not in a git repository'))
47+
}
4548

46-
cache[base] = git.dirname;
47-
tick(git.dirname);
48-
});
49+
cache[base] = git.dirname
50+
tick(git.dirname)
4951
}
5052

5153
function tick(root) {
52-
var diffs = {};
54+
var diffs = {}
55+
var revs = {originalRev: range[0], rev: range[1]}
5356

54-
gitDiffTree(path.join(root, '.git'), {originalRev: range[0], rev: range[1]})
57+
gitDiffTree(path.join(root, '.git'), revs)
5558
.on('error', next)
5659
.on('data', ondata)
57-
.on('end', onend);
60+
.on('end', onend)
5861

5962
function ondata(type, data) {
60-
var info = type === 'patch' && parse(data);
61-
var fp;
63+
var info = type === 'patch' && parse(data)
64+
var fp
6265

6366
if (info) {
64-
fp = path.resolve(root, info.path);
67+
fp = path.resolve(root, info.path)
6568

6669
/* istanbul ignore else - long diffs. */
6770
if (!(fp in diffs)) {
68-
diffs[fp] = [];
71+
diffs[fp] = []
6972
}
7073

71-
diffs[fp] = diffs[fp].concat(info.ranges);
74+
diffs[fp] = diffs[fp].concat(info.ranges)
7275
}
7376
}
7477

7578
function onend() {
76-
tock(diffs);
79+
tock(diffs)
7780
}
7881

7982
function tock(patches) {
80-
var fp = path.resolve(file.cwd, file.path);
81-
var ranges = patches[fp];
83+
var fp = path.resolve(file.cwd, file.path)
84+
var ranges = patches[fp]
8285

8386
/* Unchanged file. */
8487
if (!ranges || ranges.length === 0) {
85-
file.messages = [];
86-
return next();
88+
file.messages = []
89+
return next()
8790
}
8891

89-
file.messages = file.messages.filter(function (message) {
90-
var line = message.line;
92+
file.messages = file.messages.filter(filter)
93+
94+
next()
95+
96+
function filter(message) {
97+
var line = message.line
9198

92-
return ranges.some(function (range) {
93-
return line >= range[0] && line <= range[1];
94-
});
95-
});
99+
return ranges.some(some)
96100

97-
next();
101+
function some(range) {
102+
return line >= range[0] && line <= range[1]
103+
}
104+
}
98105
}
99106
}
100107
}
101108
}
102109

103110
function parse(data) {
104-
var lines = data.lines;
105-
var line = lines[0];
106-
var re = /^@@ -(\d+),?(\d+)? \+(\d+),?(\d+)? @@/;
107-
var match = line.match(re);
108-
var result = {path: data.bPath};
109-
var ranges = [];
110-
var start;
111-
var index;
112-
var length;
113-
var position;
114-
var no;
111+
var lines = data.lines
112+
var line = lines[0]
113+
var re = /^@@ -(\d+),?(\d+)? \+(\d+),?(\d+)? @@/
114+
var match = line.match(re)
115+
var result = {path: data.bPath}
116+
var ranges = []
117+
var start
118+
var index
119+
var length
120+
var position
121+
var no
115122

116123
/* istanbul ignore if - should not happen, maybe if
117124
* Git returns weird diffs? */
118125
if (!match) {
119-
return;
126+
return
120127
}
121128

122-
index = 0;
123-
length = lines.length;
124-
start = parseInt(match[3], 10) - 1;
125-
result.ranges = ranges;
129+
index = 0
130+
length = lines.length
131+
start = parseInt(match[3], 10) - 1
132+
result.ranges = ranges
126133

127134
while (++index < length) {
128-
line = lines[index];
135+
line = lines[index]
129136

130137
if (line.charAt(0) !== '+') {
131-
position = null;
132-
continue;
138+
position = null
139+
continue
133140
}
134141

135-
no = start + index;
142+
no = start + index
136143

137144
if (position === null || position === undefined) {
138-
position = ranges.length;
139-
ranges.push([no, no]);
145+
position = ranges.length
146+
ranges.push([no, no])
140147
} else {
141-
ranges[position][1] = no;
148+
ranges[position][1] = no
142149
}
143150
}
144151

145-
return result;
152+
return result
146153
}

package.json

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"execa": "^0.10.0",
2929
"nlcst-to-string": "^2.0.0",
3030
"nyc": "^11.1.0",
31+
"prettier": "^1.12.1",
3132
"remark-cli": "^5.0.0",
3233
"remark-preset-wooorm": "^4.0.0",
3334
"retext": "^5.0.0",
@@ -39,21 +40,27 @@
3940
"xo": "^0.21.0"
4041
},
4142
"scripts": {
42-
"build-md": "remark . -qfo",
43-
"build": "npm run build-md",
44-
"lint": "xo",
43+
"format": "remark . -qfo && prettier --write '**/*.js' && xo --fix",
4544
"test-api": "node test",
4645
"test-coverage": "nyc --reporter lcov tape test/index.js",
47-
"test": "npm run build && npm run lint && npm run test-coverage"
46+
"test": "npm run format && npm run test-coverage"
4847
},
4948
"nyc": {
5049
"check-coverage": true,
5150
"lines": 100,
5251
"functions": 100,
5352
"branches": 100
5453
},
54+
"prettier": {
55+
"tabWidth": 2,
56+
"useTabs": false,
57+
"singleQuote": true,
58+
"bracketSpacing": false,
59+
"semi": false,
60+
"trailingComma": "none"
61+
},
5562
"xo": {
56-
"space": true,
63+
"prettier": true,
5764
"esnext": false,
5865
"rules": {
5966
"no-var": "off",

readme.md

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -51,34 +51,36 @@ index 360b225..5a96b86 100644
5151
We have some natural language checking in `lint.js`:
5252

5353
```js
54-
var diff = require('unified-diff');
55-
var vfile = require('to-vfile');
56-
var unified = require('unified');
57-
var markdown = require('remark-parse');
58-
var stringify = require('remark-stringify');
59-
var remark2retext = require('remark-retext');
60-
var english = require('retext-english');
61-
var repetition = require('retext-repeated-words');
62-
var article = require('retext-indefinite-article');
63-
var report = require('vfile-reporter');
64-
65-
vfile.read('readme.md', function (err, file) {
66-
if (err) throw err;
54+
var diff = require('unified-diff')
55+
var vfile = require('to-vfile')
56+
var unified = require('unified')
57+
var markdown = require('remark-parse')
58+
var stringify = require('remark-stringify')
59+
var remark2retext = require('remark-retext')
60+
var english = require('retext-english')
61+
var repetition = require('retext-repeated-words')
62+
var article = require('retext-indefinite-article')
63+
var report = require('vfile-reporter')
64+
65+
vfile.read('readme.md', function(err, file) {
66+
if (err) throw err
6767

6868
unified()
6969
.use(markdown)
70-
.use(remark2retext, unified()
71-
.use(english)
72-
.use(repetition)
73-
.use(article)
70+
.use(
71+
remark2retext,
72+
unified()
73+
.use(english)
74+
.use(repetition)
75+
.use(article)
7476
)
7577
.use(stringify)
7678
.use(diff)
77-
.process(file, function (err) {
78-
console.error(report(err || file));
79-
process.exit(err || file.messages.length ? 1 : 0);
80-
});
81-
});
79+
.process(file, function(err) {
80+
console.error(report(err || file))
81+
process.exit(err || file.messages.length ? 1 : 0)
82+
})
83+
})
8284
```
8385

8486
`lint.js` is hooked up to run on Travis in `.travis.yml` like so:

0 commit comments

Comments
 (0)